Issue 8770057: Fixes: http://codereview.chromium.org/8651001/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8770057: Fixes: http://codereview.chromium.org/8651001/ (Closed)

Created:
9 years ago by bryeung

Modified:
9 years ago

Reviewers:
Aaron Boodman, Yusuke Sato

CC:
chromium-reviews, Erik does not do reviews, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixes: http://codereview.chromium.org/8651001/ This CL has two fixes that were suggested in the above review. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112924

Patch Set 1 #

Patch Set 2 : make it compile #

Patch Set 3 : rebase #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -7 lines)			Patch
	M	chrome/browser/extensions/extension_service.cc	View	1 2	2 chunks	+5 lines, -7 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bryeung@chromium.org/8770057/2001

9 years ago (2011-12-04 00:54:51 UTC) #4

commit-bot: I haz the power

Can't apply patch for file chrome/browser/extensions/extension_service.cc. While running patch -p1 --forward --force; patching file chrome/browser/extensions/extension_service.cc ...

9 years ago (2011-12-04 00:54:52 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bryeung@chromium.org/8770057/7001

9 years ago (2011-12-04 03:15:14 UTC) #6

Change committed as 112924

Expand Messages | Collapse Messages