Move functions out of TOUCH_UI defines.

Move functions out of TOUCH_UI defines.

BUG=105046
TEST=manually


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112798

[bryeung, 2011-11-22 21:00:01]

Yusuke: can you let me know what you think of this change?

[Yusuke Sato, 2011-11-23 15:00:41]

handwriting part LGTM. Calling handwriting APIs on Chromebook is safe; ibus
engines (except handwriting IMEs) just ignore it.

Re UI functions like CandidateClickedInputUiFunction, I think Peng would be the
better person to review.

[bryeung, 2011-11-24 16:28:57]

Adding aa for OWNERS and penghuang for candidates UI changes.

[Peng, 2011-11-24 17:11:14]

http://codereview.chromium.org/8651001/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_function_dispatcher.cc (right):

http://codereview.chromium.org/8651001/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_function_dispatcher.cc:82: #include
"chrome/browser/extensions/extension_input_ui_api.h"
I think it is safer if we only enable input_ui apis with virtual keyboard.

And if it is necessary, we could re-enable it later.

http://codereview.chromium.org/8651001/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_function_dispatcher.cc:328:
RegisterFunction<CandidateClickedInputUiFunction>();
ditto

http://codereview.chromium.org/8651001/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_function_dispatcher.cc:409: // Input
ditto

http://codereview.chromium.org/8651001/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_service.cc (right):

http://codereview.chromium.org/8651001/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_service.cc:503: #if defined(OS_CHROMEOS) &&
defined(USE_VIRTUAL_KEYBOARD)
Without it, the extension can not receive any ime related events (like
updateLookupTable, updatePreeditText and etc), and then apis in inputui are not
useful anymore. So I suggest disable apis in inputui if virtual_keyboard is not
used.

[bryeung, 2011-11-29 22:29:17]

Peng: I've moved the input_ui things into USE_VIRTUAL_KEYBOARD checks.

[Peng, 2011-11-30 16:58:58]

On 2011/11/29 22:29:17, bryeung wrote:
> Peng: I've moved the input_ui things into USE_VIRTUAL_KEYBOARD checks.

lgtm

[bryeung, 2011-11-30 17:00:24]

Aaron: can you look this over for OWNERS?  Thanks!

[bryeung, 2011-12-02 16:16:14]

Aaron: do you have time to look at this today?

[Aaron Boodman, 2011-12-02 20:13:58]

http://codereview.chromium.org/8651001/diff/8001/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_service.cc (right):

http://codereview.chromium.org/8651001/diff/8001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_service.cc:1015:
chromeos::input_method::InputMethodManager* input_method_manager =
Move this closer to where it is used, to reduce the number of ifdefs and make it
easier to read.

http://codereview.chromium.org/8651001/diff/8001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_service.cc:1029: const bool is_system =
What is is_system supposed to mean? There might be a better way to determine it,
for example location() == COMPONENT.

[Aaron Boodman, 2011-12-02 20:30:21]

LGTM, but please follow up on the two comment separately.

[commit-bot: I haz the power, 2011-12-02 20:32:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bryeung@chromium.org/8651001/8001

[commit-bot: I haz the power, 2011-12-02 21:54:15]

Change committed as 112798