Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: chrome/browser/automation/testing_automation_provider.cc

Issue 8770027: Get rid of the ChildProcessInfo class. It was carrying unnecessary data, and the fact that some p... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/metrics/metrics_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/automation/testing_automation_provider.cc
===================================================================
--- chrome/browser/automation/testing_automation_provider.cc (revision 112500)
+++ chrome/browser/automation/testing_automation_provider.cc (working copy)
@@ -2723,11 +2723,11 @@
// since we need their handle.
if ((*iter)->handle() == base::kNullProcessHandle)
continue;
- ChildProcessInfo* info = *iter;
DictionaryValue* item = new DictionaryValue;
- item->SetString("name", info->name());
- item->SetString("type", content::GetProcessTypeNameInEnglish(info->type()));
- item->SetInteger("pid", base::GetProcId(info->handle()));
+ item->SetString("name", iter->name());
+ item->SetString("type",
+ content::GetProcessTypeNameInEnglish(iter->type()));
+ item->SetInteger("pid", base::GetProcId(iter->handle()));
child_processes->Append(item);
}
}
« no previous file with comments | « no previous file | chrome/browser/metrics/metrics_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698