chrome/browser/metrics/metrics_service.cc - Issue 8770027: Get rid of the ChildProcessInfo class. It was carrying unnecessary data, and the fact that some p...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_service.cc

Issue 8770027: Get rid of the ChildProcessInfo class. It was carrying unnecessary data, and the fact that some p... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/automation/testing_automation_provider.cc ('k') | chrome/browser/task_manager/task_manager_resource_providers.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/metrics_service.cc

===================================================================

--- chrome/browser/metrics/metrics_service.cc (revision 112500)

+++ chrome/browser/metrics/metrics_service.cc (working copy)

@@ -1339,13 +1339,13 @@

int type,

const content::NotificationSource& source,

const content::NotificationDetails& details) {

- content::Details<ChildProcessInfo> child_details(details);

- const string16& child_name = child_details->name();

+ content::Details<content::ChildProcessData> child_details(details);

+ const string16& child_name = child_details->name;

if (child_process_stats_buffer_.find(child_name) ==

child_process_stats_buffer_.end()) {

child_process_stats_buffer_[child_name] =

- ChildProcessStats(child_details->type());

+ ChildProcessStats(child_details->type);

}

ChildProcessStats& stats = child_process_stats_buffer_[child_name];

@@ -1362,7 +1362,7 @@

stats.process_crashes++;

// Exclude plugin crashes from the count below because we report them via

// a separate UMA metric.

- if (!IsPluginProcess(child_details->type())) {

+ if (!IsPluginProcess(child_details->type)) {

IncrementPrefValue(prefs::kStabilityChildProcessCrashCount);

}

break;