Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 8770027: Get rid of the ChildProcessInfo class. It was carrying unnecessary data, and the fact that some p... (Closed)

Created:
9 years ago by jam
Modified:
9 years ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, kkania, yoshiki+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., robertshield
Visibility:
Public.

Description

Get rid of the ChildProcessInfo class. It was carrying unnecessary data, and the fact that some processes inherited from it was confusing. There's now a simpler struct, content::ChildProcessData. BrowserChildProcessHost uses composition instead of inheritence. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112597

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -263 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.h View 3 chunks +8 lines, -13 lines 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 8 chunks +15 lines, -18 lines 0 comments Download
M chrome/browser/task_manager/task_manager_worker_resource_provider.cc View 13 chunks +25 lines, -24 lines 0 comments Download
M chrome/browser/ui/webui/workers_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_child_process_host.h View 5 chunks +13 lines, -3 lines 0 comments Download
M content/browser/browser_child_process_host.cc View 5 chunks +20 lines, -25 lines 0 comments Download
M content/browser/mach_broker_mac.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/plugin_data_remover_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/mock_render_process_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/common/child_process_host.h View 1 chunk +13 lines, -0 lines 0 comments Download
M content/common/child_process_host.cc View 3 chunks +25 lines, -2 lines 0 comments Download
D content/common/child_process_info.h View 1 chunk +0 lines, -83 lines 0 comments Download
D content/common/child_process_info.cc View 1 chunk +0 lines, -65 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
A content/public/browser/child_process_data.h View 1 chunk +38 lines, -0 lines 0 comments Download
M content/public/browser/notification_types.h View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
9 years ago (2011-12-01 23:26:53 UTC) #1
jam
Elliot: can you have a look instead?
9 years ago (2011-12-02 00:24:23 UTC) #2
Elliot Glaysher
9 years ago (2011-12-02 00:38:39 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698