Added a download file factory to the download file manager, for testing.

content/browser/renderer_host/resource_dispatcher_host.cc

Index: content/browser/renderer_host/resource_dispatcher_host.cc
diff --git a/content/browser/renderer_host/resource_dispatcher_host.cc b/content/browser/renderer_host/resource_dispatcher_host.cc
index fb0f1c33e0108169ae32d8423f1e4cc823466d0b..536c09e71bd68fb917cda8eb733bf51274999a10 100644
--- a/content/browser/renderer_host/resource_dispatcher_host.cc
+++ b/content/browser/renderer_host/resource_dispatcher_host.cc
@@ -27,6 +27,7 @@
 #include "content/browser/chrome_blob_storage_context.h"
 #include "content/browser/cross_site_request_manager.h"
 #include "content/browser/download/download_file_manager.h"
+#include "content/browser/download/download_file_impl.h"
 #include "content/browser/download/download_id_factory.h"
 #include "content/browser/download/download_manager.h"
 #include "content/browser/download/download_resource_handler.h"
@@ -119,6 +120,25 @@ const int kAllNetErrorCodes[] = {
 #undef NET_ERROR
 };
 
+class StandardDownloadFileFactory

[Randy Smith (Not in Mondays), 2011/12/05 22:25:38]

I don't think this belongs in ResourceDispatcherHost; it's really part of the
download code.  I'm inclined to think that means a new file, but that seems like
a real waste of directory space.  I'll ping Chris on whether it's reasonable to
just declare DownloadFileFactoryImpl in download_file_manager.h when I respond
to this review.

I'd also call it DownloadFileFactoryImpl.

[cbentzel, 2011/12/07 18:58:21]

I agree that the definition doesn't belong in RDH.

I think it would be fine to put it in download_file_manager.h

I'd also be fine with putting it in download_file_factory.h and moving the
factory interface out of DownloadFileManager.

One other option - passing in a NULL DownloadFileFactory into
DownloadFileManager could indicate that the DownloadFileManager should create a
StandardDownloadFileFactory [or whatever the new name is]. That way you don't
need to expose it at all.

[ahendrickson, 2011/12/07 19:55:15]

I like option 3.  Done.

[ahendrickson, 2011/12/07 19:55:15]

Renamed, and moved into DownloadFileManager.cc.

Using Chris' NULL parameter option.

+    : public DownloadFileManager::DownloadFileFactory {
+ public:
+  StandardDownloadFileFactory() {}
+
+  virtual DownloadFile* GetFile(DownloadCreateInfo* info,
+                                const DownloadRequestHandle& request_handle,
+                                DownloadManager* download_manager) OVERRIDE;
+};
+
+DownloadFile* StandardDownloadFileFactory::GetFile(
+    DownloadCreateInfo* info,
+    const DownloadRequestHandle& request_handle,
+    DownloadManager* download_manager) {
+  return new DownloadFileImpl(info,
+                              new DownloadRequestHandle(request_handle),
+                              download_manager);
+}
+
 // Aborts a request before an URLRequest has actually been created.
 void AbortRequestBeforeItStarts(ResourceMessageFilter* filter,
                                 IPC::Message* sync_result,
@@ -292,7 +312,9 @@ void OnSwapOutACKHelper(int render_process_id, int render_view_id) {
 ResourceDispatcherHost::ResourceDispatcherHost(
     const ResourceQueue::DelegateSet& resource_queue_delegates)
     : ALLOW_THIS_IN_INITIALIZER_LIST(
-          download_file_manager_(new DownloadFileManager(this))),
+          download_file_manager_(new DownloadFileManager(
+                                     this,
+                                     new StandardDownloadFileFactory))),
       ALLOW_THIS_IN_INITIALIZER_LIST(
           save_file_manager_(new SaveFileManager(this))),
       request_id_(-1),