Added a download file factory to the download file manager, for testing.

content/browser/renderer_host/resource_dispatcher_host.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // See http://dev.chromium.org/developers/design-documents/multi-process-resource-loading
 
 #include "content/browser/renderer_host/resource_dispatcher_host.h"
 
 #include <set>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/debug/alias.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "base/shared_memory.h"
 #include "base/stl_util.h"
 #include "base/third_party/dynamic_annotations/dynamic_annotations.h"
 #include "content/browser/appcache/chrome_appcache_service.h"
 #include "content/browser/cert_store.h"
 #include "content/browser/child_process_security_policy.h"
 #include "content/browser/chrome_blob_storage_context.h"
 #include "content/browser/cross_site_request_manager.h"
 #include "content/browser/download/download_file_manager.h"
+#include "content/browser/download/download_file_impl.h"
 #include "content/browser/download/download_id_factory.h"
 #include "content/browser/download/download_manager.h"
 #include "content/browser/download/download_resource_handler.h"
 #include "content/browser/download/save_file_manager.h"
 #include "content/browser/download/save_file_resource_handler.h"
 #include "content/browser/plugin_service.h"
 #include "content/browser/renderer_host/async_resource_handler.h"
 #include "content/browser/renderer_host/buffered_resource_handler.h"
 #include "content/browser/renderer_host/cross_site_resource_handler.h"
 #include "content/browser/renderer_host/global_request_id.h"
@@ skipping 72 matching lines @@
 const int kUserGestureWindowMs = 3500;
 
 // All possible error codes from the network module. Note that the error codes
 // are all positive (since histograms expect positive sample values).
 const int kAllNetErrorCodes[] = {
 #define NET_ERROR(label, value) -(value),
 #include "net/base/net_error_list.h"
 #undef NET_ERROR
 };
 
+class StandardDownloadFileFactory

[Randy Smith (Not in Mondays), 2011/12/05 22:25:38]

I don't think this belongs in ResourceDispatcherHost; it's really part of the
download code.  I'm inclined to think that means a new file, but that seems like
a real waste of directory space.  I'll ping Chris on whether it's reasonable to
just declare DownloadFileFactoryImpl in download_file_manager.h when I respond
to this review.

I'd also call it DownloadFileFactoryImpl.

[cbentzel, 2011/12/07 18:58:21]

I agree that the definition doesn't belong in RDH.

I think it would be fine to put it in download_file_manager.h

I'd also be fine with putting it in download_file_factory.h and moving the
factory interface out of DownloadFileManager.

One other option - passing in a NULL DownloadFileFactory into
DownloadFileManager could indicate that the DownloadFileManager should create a
StandardDownloadFileFactory [or whatever the new name is]. That way you don't
need to expose it at all.

[ahendrickson, 2011/12/07 19:55:15]

I like option 3.  Done.

[ahendrickson, 2011/12/07 19:55:15]

Renamed, and moved into DownloadFileManager.cc.

Using Chris' NULL parameter option.

+    : public DownloadFileManager::DownloadFileFactory {
+ public:
+  StandardDownloadFileFactory() {}
+
+  virtual DownloadFile* GetFile(DownloadCreateInfo* info,
+                                const DownloadRequestHandle& request_handle,
+                                DownloadManager* download_manager) OVERRIDE;
+};
+
+DownloadFile* StandardDownloadFileFactory::GetFile(
+    DownloadCreateInfo* info,
+    const DownloadRequestHandle& request_handle,
+    DownloadManager* download_manager) {
+  return new DownloadFileImpl(info,
+                              new DownloadRequestHandle(request_handle),
+                              download_manager);
+}
+
 // Aborts a request before an URLRequest has actually been created.
 void AbortRequestBeforeItStarts(ResourceMessageFilter* filter,
                                 IPC::Message* sync_result,
                                 int route_id,
                                 int request_id) {
   net::URLRequestStatus status(net::URLRequestStatus::FAILED,
                                net::ERR_ABORTED);
   if (sync_result) {
     content::SyncLoadResult result;
     result.status = status;
@@ skipping 153 matching lines @@
                                                render_view_id);
   if (rvh)
     rvh->OnSwapOutACK();
 }
 
 }  // namespace
 
 ResourceDispatcherHost::ResourceDispatcherHost(
     const ResourceQueue::DelegateSet& resource_queue_delegates)
     : ALLOW_THIS_IN_INITIALIZER_LIST(
-          download_file_manager_(new DownloadFileManager(this))),
+          download_file_manager_(new DownloadFileManager(
+                                     this,
+                                     new StandardDownloadFileFactory))),
       ALLOW_THIS_IN_INITIALIZER_LIST(
           save_file_manager_(new SaveFileManager(this))),
       request_id_(-1),
       ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)),
       is_shutdown_(false),
       max_outstanding_requests_cost_per_process_(
           kMaxOutstandingRequestsCostPerProcess),
       filter_(NULL),
       delegate_(NULL),
       allow_cross_origin_auth_prompt_(false) {
@@ skipping 1866 matching lines @@
   return HTTP_AUTH_RESOURCE_BLOCKED_CROSS;
 }
 
 bool ResourceDispatcherHost::allow_cross_origin_auth_prompt() {
   return allow_cross_origin_auth_prompt_;
 }
 
 void ResourceDispatcherHost::set_allow_cross_origin_auth_prompt(bool value) {
   allow_cross_origin_auth_prompt_ = value;
 }