Issue 8769037: Quickfix for DoMathPowHalf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8769037: Quickfix for DoMathPowHalf. (Closed)

Created:
9 years ago by Yang

Modified:
9 years ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Quickfix for DoMathPowHalf. TEST=regress-397.js Committed: http://code.google.com/p/v8/source/detail?r=10140

Patch Set 1 #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -11 lines)			Patch
M	src/ia32/assembler-ia32.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/assembler-ia32.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1 chunk	+3 lines, -7 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+19 lines, -0 lines	1 comment	Download
M	test/mjsunit/regress/regress-397.js	View	1 chunk	+13 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

9 years ago (2011-12-02 13:11:02 UTC) #2

When you add an instruction to the assembler you should add it to the
disassembler and to the disassembler and assembler cctests.

LGTM

http://codereview.chromium.org/8769037/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):

http://codereview.chromium.org/8769037/diff/1/src/ia32/lithium-codegen-ia32.c...
src/ia32/lithium-codegen-ia32.cc:2944: __ push(ecx);
This is nasty.  We have support for allocating temporary registers in Lithium,
so we don't need to push and pop if we have registers.

Expand Messages | Collapse Messages