Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Unified Diff: content/renderer/render_view_impl.cc

Issue 8769026: Content-initiated navigations from chrome:// pages to chrome:// pages in a new tab must be browse... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
===================================================================
--- content/renderer/render_view_impl.cc (revision 112362)
+++ content/renderer/render_view_impl.cc (working copy)
@@ -2043,6 +2043,10 @@
// opening a new window). But we sometimes navigate to about:blank to clear a
// tab, and we want to still allow that.
//
+ // Note: navigating to a new chrome:// scheme from within a chrome:// page
+ // must be a browser navigation so that the browser can first register the
+ // new associated data source.
+ //
// Note: we do this only for GET requests because our mechanism for switching
// processes only issues GET requests. In particular, POST requests don't
// work, because this mechanism does not preserve form POST data. If it
@@ -2065,7 +2069,8 @@
bool should_fork =
(enabled_bindings_ & content::BINDINGS_POLICY_WEB_UI) ||
frame->isViewSourceModeEnabled() ||
- url.SchemeIs(chrome::kViewSourceScheme);
+ url.SchemeIs(chrome::kViewSourceScheme) ||
+ url.SchemeIs("chrome");
jam 2011/12/02 02:29:19 nit: i assume there's a constant somewhere for "ch
if (!should_fork) {
// Give the embedder a chance.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698