Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 8769024: base::Bind: Convert AppCacheHelper::DeleteAppCachesForOrigin. (Closed)

Created:
9 years ago by James Hawkins
Modified:
9 years ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, michaeln, Aaron Boodman, Erik does not do reviews, darin-cc_chromium.org, mihaip+watch_chromium.org
Visibility:
Public.

Description

base::Bind: Convert AppCacheHelper::DeleteAppCachesForOrigin. BUG=none TEST=none R=groby@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112635

Patch Set 1 #

Total comments: 2

Patch Set 2 : Test build fix. #

Patch Set 3 : Build fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -33 lines) Patch
M chrome/browser/extensions/extension_data_deleter.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/appcache/appcache_quota_client.h View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/appcache/appcache_quota_client.cc View 5 chunks +12 lines, -10 lines 0 comments Download
M webkit/appcache/appcache_service.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_service.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M webkit/appcache/appcache_service_unittest.cc View 1 7 chunks +9 lines, -7 lines 0 comments Download
M webkit/appcache/mock_appcache_service.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M webkit/appcache/mock_appcache_service.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
James Hawkins
9 years ago (2011-12-01 23:49:27 UTC) #1
groby-ooo-7-16
http://codereview.chromium.org/8769024/diff/1/webkit/appcache/appcache_quota_client.cc File webkit/appcache/appcache_quota_client.cc (left): http://codereview.chromium.org/8769024/diff/1/webkit/appcache/appcache_quota_client.cc#oldcode59 webkit/appcache/appcache_quota_client.cc:59: service_delete_callback_ = NULL; Doesn't the new code require a ...
9 years ago (2011-12-01 23:55:51 UTC) #2
James Hawkins
http://codereview.chromium.org/8769024/diff/1/webkit/appcache/appcache_quota_client.cc File webkit/appcache/appcache_quota_client.cc (left): http://codereview.chromium.org/8769024/diff/1/webkit/appcache/appcache_quota_client.cc#oldcode59 webkit/appcache/appcache_quota_client.cc:59: service_delete_callback_ = NULL; On 2011/12/01 23:55:51, groby wrote: > ...
9 years ago (2011-12-01 23:58:13 UTC) #3
groby-ooo-7-16
9 years ago (2011-12-02 00:02:22 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698