Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: webkit/appcache/appcache_quota_client.cc

Issue 8769024: base::Bind: Convert AppCacheHelper::DeleteAppCachesForOrigin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Build fix. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/appcache/appcache_quota_client.h ('k') | webkit/appcache/appcache_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/appcache/appcache_quota_client.cc
diff --git a/webkit/appcache/appcache_quota_client.cc b/webkit/appcache/appcache_quota_client.cc
index b071910926a95af9d408c33518b277ad7e0c0c9f..ed36956c50e957f8320c6891335eb029e2ba1668 100644
--- a/webkit/appcache/appcache_quota_client.cc
+++ b/webkit/appcache/appcache_quota_client.cc
@@ -9,6 +9,7 @@
#include <set>
#include "base/bind.h"
+#include "base/bind_helpers.h"
#include "webkit/appcache/appcache_service.h"
using quota::QuotaClient;
@@ -34,9 +35,10 @@ namespace appcache {
AppCacheQuotaClient::AppCacheQuotaClient(AppCacheService* service)
: ALLOW_THIS_IN_INITIALIZER_LIST(service_delete_callback_(
- new net::CancelableOldCompletionCallback<AppCacheQuotaClient>(
- this, &AppCacheQuotaClient::DidDeleteAppCachesForOrigin))),
- service_(service), appcache_is_ready_(false),
+ base::Bind(&AppCacheQuotaClient::DidDeleteAppCachesForOrigin,
+ base::Unretained(this)))),
+ service_(service),
+ appcache_is_ready_(false),
quota_manager_is_destroyed_(false) {
}
@@ -54,10 +56,9 @@ void AppCacheQuotaClient::OnQuotaManagerDestroyed() {
DeletePendingRequests();
if (!current_delete_request_callback_.is_null()) {
current_delete_request_callback_.Reset();
- service_delete_callback_.release()->Cancel();
- } else {
- service_delete_callback_ = NULL;
+ service_delete_callback_.Cancel();
}
+
quota_manager_is_destroyed_ = true;
if (!service_)
delete this;
@@ -136,7 +137,9 @@ void AppCacheQuotaClient::DeleteOriginData(const GURL& origin,
DidDeleteAppCachesForOrigin(net::OK);
return;
}
- service_->DeleteAppCachesForOrigin(origin, service_delete_callback_);
+
+ service_->DeleteAppCachesForOrigin(
+ origin, service_delete_callback_.callback());
}
void AppCacheQuotaClient::DidDeleteAppCachesForOrigin(int rv) {
@@ -223,10 +226,9 @@ void AppCacheQuotaClient::NotifyAppCacheDestroyed() {
if (!current_delete_request_callback_.is_null()) {
current_delete_request_callback_.Run(quota::kQuotaErrorAbort);
current_delete_request_callback_.Reset();
- service_delete_callback_.release()->Cancel();
- } else {
- service_delete_callback_ = NULL;
+ service_delete_callback_.Cancel();
}
+
if (quota_manager_is_destroyed_)
delete this;
}
« no previous file with comments | « webkit/appcache/appcache_quota_client.h ('k') | webkit/appcache/appcache_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698