Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 8769016: Use the new base::mac::GetValueFromDictionary<>() method. (Closed)

Created:
9 years ago by KushalP
Modified:
9 years ago
CC:
chromium-reviews, Paweł Hajdan Jr., dcheng, brettw-cc_chromium.org
Visibility:
Public.

Description

Use the new base::mac::GetValueFromDictionary<>() method. Remove all cases of the old method signature (and related tests) and use the new form. BUG=104200 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112553

Patch Set 1 #

Patch Set 2 : update example comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -72 lines) Patch
M base/mac/foundation_util.h View 1 3 chunks +8 lines, -19 lines 0 comments Download
M base/mac/foundation_util.mm View 2 chunks +13 lines, -34 lines 0 comments Download
M base/mac/mac_util_unittest.mm View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
KushalP
I've gone through and removed traces of the old method. The only thing left before ...
9 years ago (2011-12-01 18:22:12 UTC) #1
Mark Mentovai
LGTM
9 years ago (2011-12-01 19:36:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kushi.p@gmail.com/8769016/1005
9 years ago (2011-12-01 20:00:48 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-01 22:13:01 UTC) #4
Change committed as 112553

Powered by Google App Engine
This is Rietveld 408576698