Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: base/mac/mac_util_unittest.mm

Issue 8769016: Use the new base::mac::GetValueFromDictionary<>() method. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: update example comment Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/mac/foundation_util.mm ('k') | chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/mac/mac_util_unittest.mm
diff --git a/base/mac/mac_util_unittest.mm b/base/mac/mac_util_unittest.mm
index dd860a66872930868b8dd12e856c57d50101696f..04f8ddf1b60d44cdadae633378a06ea8f4be73a3 100644
--- a/base/mac/mac_util_unittest.mm
+++ b/base/mac/mac_util_unittest.mm
@@ -121,21 +121,6 @@ TEST_F(MacUtilTest, TestExcludeFileFromBackups) {
EXPECT_FALSE(excluded_by_path);
}
-TEST_F(MacUtilTest, TestGetValueFromDictionary) {
- ScopedCFTypeRef<CFMutableDictionaryRef> dict(
- CFDictionaryCreateMutable(0, 0,
- &kCFTypeDictionaryKeyCallBacks,
- &kCFTypeDictionaryValueCallBacks));
- CFDictionarySetValue(dict.get(), CFSTR("key"), CFSTR("value"));
-
- EXPECT_TRUE(CFEqual(CFSTR("value"),
- GetValueFromDictionary(
- dict, CFSTR("key"), CFStringGetTypeID())));
- EXPECT_FALSE(GetValueFromDictionary(dict, CFSTR("key"), CFNumberGetTypeID()));
- EXPECT_FALSE(GetValueFromDictionary(
- dict, CFSTR("no-exist"), CFStringGetTypeID()));
-}
-
TEST_F(MacUtilTest, CopyNSImageToCGImage) {
scoped_nsobject<NSImage> nsImage(
[[NSImage alloc] initWithSize:NSMakeSize(20, 20)]);
« no previous file with comments | « base/mac/foundation_util.mm ('k') | chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698