Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 8769013: Remove BrowserThread::UnsafeGetBrowserThread, add UnsafeGetMessageLoopForThread. (Closed)

Created:
9 years ago by Jói
Modified:
9 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Remove BrowserThread::UnsafeGetBrowserThread, add UnsafeGetMessageLoopForThread. This also removes several accessors on BrowserProcess that are no longer used. I wanted to remove all retrieval of MessageLoop objects via BrowserThread, but this proved harder than it looked, because several net:: classes use MessageLoop and have fairly deep assumptions that it is a real MessageLoop, e.g. they use MessageLoopForIO with its IO observers and so forth. Therefore, we now have UnsafeGetMessageLoopForThread but UnsafeGetBrowserThread is gone. TBR=abodenha@chromium.org BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113377

Patch Set 1 : Ready for review. #

Patch Set 2 : Merge to head. #

Patch Set 3 : Fix Win build failures. #

Patch Set 4 : Merge to lkgr. #

Patch Set 5 : Merge to LKGR (pure merge). #

Patch Set 6 : Fix breakage in BaseSessionService. #

Patch Set 7 : Fix SessionService unit test. #

Patch Set 8 : Merge lkgr (pure merge). #

Patch Set 9 : Merge to lkgr (pure merge). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -195 lines) Patch
M chrome/browser/browser_process.h View 1 2 3 2 chunks +8 lines, -28 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 2 3 4 5 6 7 3 chunks +4 lines, -17 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/boot_times_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/version_loader.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/external_protocol/external_protocol_handler.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/net/chrome_url_request_context.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/net/proxy_service_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/printer_manager_dialog_win.cc View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/sessions/base_session_service.h View 1 2 3 4 5 5 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/sessions/base_session_service.cc View 1 2 3 4 5 6 7 8 6 chunks +35 lines, -36 lines 0 comments Download
M chrome/browser/sessions/session_service.cc View 1 2 3 4 5 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/browser/ui/browser_init.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/advanced_options_utils_win.cc View 1 2 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/test/base/testing_browser_process.h View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/test/base/testing_browser_process.cc View 1 2 3 1 chunk +0 lines, -14 lines 0 comments Download
M content/browser/browser_thread_impl.cc View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -6 lines 0 comments Download
M content/public/browser/browser_thread.h View 1 2 3 4 5 6 7 8 1 chunk +7 lines, -31 lines 0 comments Download
M content/shell/shell_browser_context.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Jói
jam: Main reviewer. battre: chrome/net/OWNERS.
9 years ago (2011-12-01 17:45:45 UTC) #1
battre
vacuously LGTM for chrome/net/* - there are no files in chrome/net ;-)
9 years ago (2011-12-01 18:00:13 UTC) #2
jam
lgtm Is the plan is still to remove UnsafeGetMessageLoopForThread, even later? At the very least, ...
9 years ago (2011-12-01 19:23:23 UTC) #3
Jói
Thanks for the super-fast reviews! > Is the plan is still to remove UnsafeGetMessageLoopForThread, even ...
9 years ago (2011-12-01 22:40:06 UTC) #4
jam
On 2011/12/01 22:40:06, Jói wrote: > Thanks for the super-fast reviews! > > > Is ...
9 years ago (2011-12-01 23:30:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/8769013/6001
9 years ago (2011-12-02 15:26:59 UTC) #6
commit-bot: I haz the power
Presubmit check for 8769013-6001 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-12-02 15:27:08 UTC) #7
Jói
TBR=abodenha@chromium.org for trivial update to a file requiring chrome/browser/printing/OWNERS approval. Cheers, Jói
9 years ago (2011-12-02 15:35:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/8769013/6001
9 years ago (2011-12-02 15:35:26 UTC) #9
commit-bot: I haz the power
Try job failure for 8769013-6001 (retry) on win_rel for step "compile" (clobber build). It's a ...
9 years ago (2011-12-02 16:30:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/8769013/7001
9 years ago (2011-12-02 16:39:49 UTC) #11
Albert Bodenhamer
lgtm
9 years ago (2011-12-02 16:56:19 UTC) #12
commit-bot: I haz the power
Try job failure for 8769013-7001 (retry) on linux_rel for steps "unit_tests, browser_tests, ui_tests". It's a ...
9 years ago (2011-12-02 18:36:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/8769013/8001
9 years ago (2011-12-05 11:45:42 UTC) #14
commit-bot: I haz the power
Try job failure for 8769013-8001 (retry) on linux_rel for steps "unit_tests, browser_tests, ui_tests". It's a ...
9 years ago (2011-12-05 13:28:46 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/8769013/15003
9 years ago (2011-12-05 14:57:07 UTC) #16
commit-bot: I haz the power
Try job failure for 8769013-15003 (retry) on linux_rel for step "unit_tests". It's a second try, ...
9 years ago (2011-12-05 15:55:46 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/8769013/25001
9 years ago (2011-12-07 10:57:30 UTC) #18
commit-bot: I haz the power
9 years ago (2011-12-07 12:03:45 UTC) #19
Change committed as 113377

Powered by Google App Engine
This is Rietveld 408576698