Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: chrome/browser/browser_process.h

Issue 8769013: Remove BrowserThread::UnsafeGetBrowserThread, add UnsafeGetMessageLoopForThread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to lkgr (pure merge). Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/browser_process_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_process.h
diff --git a/chrome/browser/browser_process.h b/chrome/browser/browser_process.h
index c2bb8a7c0beda07866cf0a0de2f1cc8051a771a9..abc4e14175f7c8f5307f3e3ee3d714c5e076ab74 100644
--- a/chrome/browser/browser_process.h
+++ b/chrome/browser/browser_process.h
@@ -44,10 +44,6 @@ class TabCloseableStateWatcher;
class ThumbnailGenerator;
class WatchDogThread;
-namespace base {
-class Thread;
-}
-
#if defined(OS_CHROMEOS)
namespace browser {
class OomPriorityManager;
@@ -114,35 +110,19 @@ class BrowserProcess {
// Returns the manager for desktop notifications.
virtual NotificationUIManager* notification_ui_manager() = 0;
- // Returns the thread that we perform I/O coordination on (network requests,
- // communication with renderers, etc.
- // NOTE: You should ONLY use this to pass to IPC or other objects which must
- // need a MessageLoop*. If you just want to post a task, use
- // BrowserThread::PostTask (or other variants) as they take care of checking
- // that a thread is still alive, race conditions, lifetime differences etc.
- // If you still must use this check the return value for NULL.
+ // Returns the state object for the thread that we perform I/O
+ // coordination on (network requests, communication with renderers,
+ // etc.
+ //
+ // Can be NULL close to startup and shutdown.
+ //
+ // NOTE: If you want to post a task to the IO thread, use
+ // BrowserThread::PostTask (or other variants).
virtual IOThread* io_thread() = 0;
- // Returns the thread that we perform random file operations on. For code
- // that wants to do I/O operations (not network requests or even file: URL
- // requests), this is the thread to use to avoid blocking the UI thread.
- // It might be nicer to have a thread pool for this kind of thing.
- virtual base::Thread* file_thread() = 0;
-
- // Returns the thread that is used for database operations such as the web
- // database. History has its own thread since it has much higher traffic.
- virtual base::Thread* db_thread() = 0;
-
// Returns the thread that is used for health check of all browser threads.
virtual WatchDogThread* watchdog_thread() = 0;
-#if defined(OS_CHROMEOS)
- // Returns thread for websocket to TCP proxy.
- // TODO(dilmah): remove this thread. Instead provide this functionality via
- // hooks into websocket bridge layer.
- virtual base::Thread* web_socket_proxy_thread() = 0;
-#endif
-
virtual policy::BrowserPolicyConnector* browser_policy_connector() = 0;
virtual IconManager* icon_manager() = 0;
« no previous file with comments | « no previous file | chrome/browser/browser_process_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698