Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8769011: Reland change for aura tooltips that was revert due to build break: (Closed)

Created:
9 years ago by varunjain
Modified:
9 years ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, dhollowa+watch_chromium.org, jam, penghuang+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, tfarina, James Su
Visibility:
Public.

Description

Reland change for aura tooltips that was revert due to build break: http://codereview.chromium.org/8747022 BUG=97249 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112535

Patch Set 1 : patch #

Total comments: 1

Patch Set 2 : moved exclude to gyp file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+641 lines, -331 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/aura/aura.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/client/aura_constants.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/client/aura_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
A ui/aura/client/tooltip_client.h View 1 chunk +32 lines, -0 lines 0 comments Download
M ui/aura_shell/aura_shell.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/aura_shell/shell.h View 3 chunks +7 lines, -0 lines 0 comments Download
M ui/aura_shell/shell.cc View 3 chunks +14 lines, -0 lines 0 comments Download
A ui/aura_shell/shell_tooltip_manager.h View 1 chunk +71 lines, -0 lines 0 comments Download
A ui/aura_shell/shell_tooltip_manager.cc View 1 chunk +281 lines, -0 lines 0 comments Download
A ui/views/test/test_tooltip_client.h View 1 chunk +32 lines, -0 lines 0 comments Download
A ui/views/test/test_tooltip_client.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 3 chunks +5 lines, -8 lines 0 comments Download
A ui/views/widget/tooltip_manager_aura.h View 1 chunk +42 lines, -0 lines 0 comments Download
A ui/views/widget/tooltip_manager_aura.cc View 1 chunk +107 lines, -0 lines 0 comments Download
D ui/views/widget/tooltip_manager_views.h View 1 chunk +0 lines, -80 lines 0 comments Download
D ui/views/widget/tooltip_manager_views.cc View 1 chunk +0 lines, -239 lines 0 comments Download
M views/views.gyp View 1 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
varunjain
9 years ago (2011-12-01 17:50:08 UTC) #1
Ben Goodger (Google)
http://codereview.chromium.org/8769011/diff/2001/ui/views/test/test_tooltip_client.cc File ui/views/test/test_tooltip_client.cc (right): http://codereview.chromium.org/8769011/diff/2001/ui/views/test/test_tooltip_client.cc#newcode15 ui/views/test/test_tooltip_client.cc:15: #if defined(USE_AURA) we shouldn't be doing this in aura ...
9 years ago (2011-12-01 17:55:40 UTC) #2
varunjain
On 2011/12/01 17:55:40, Ben Goodger (Google) wrote: > http://codereview.chromium.org/8769011/diff/2001/ui/views/test/test_tooltip_client.cc > File ui/views/test/test_tooltip_client.cc (right): > > ...
9 years ago (2011-12-01 19:10:15 UTC) #3
Ben Goodger (Google)
lgtm
9 years ago (2011-12-01 20:04:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/8769011/3022
9 years ago (2011-12-01 20:05:06 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-01 21:21:12 UTC) #6 
Change committed as 112535

Powered by Google App Engine
This is Rietveld 408576698