Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: ui/views/widget/native_widget_aura.cc

Issue 8769011: Reland change for aura tooltips that was revert due to build break: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: moved exclude to gyp file Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/widget/native_widget_aura.h ('k') | ui/views/widget/tooltip_manager_aura.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/native_widget_aura.cc
diff --git a/ui/views/widget/native_widget_aura.cc b/ui/views/widget/native_widget_aura.cc
index bcb14a7d6b89cb5c96a571735034fa902edebcff..8308a45a7f6fb7945ee15990328b2bc943ab454e 100644
--- a/ui/views/widget/native_widget_aura.cc
+++ b/ui/views/widget/native_widget_aura.cc
@@ -22,7 +22,8 @@
#include "ui/gfx/screen.h"
#include "ui/views/widget/drop_helper.h"
#include "ui/views/widget/native_widget_delegate.h"
-#include "ui/views/widget/tooltip_manager_views.h"
+#include "ui/views/widget/tooltip_manager_aura.h"
+#include "ui/views/widget/widget_delegate.h"
#if defined(OS_WIN)
#include "base/win/scoped_gdi_object.h"
@@ -156,10 +157,8 @@ void NativeWidgetAura::InitNativeWidget(const Widget::InitParams& params) {
delegate_->OnNativeWidgetSizeChanged(params.bounds.size());
can_activate_ = params.can_activate;
DCHECK(GetWidget()->GetRootView());
- if (params.type != Widget::InitParams::TYPE_TOOLTIP && !params.child) {
- views::TooltipManagerViews* manager = new views::TooltipManagerViews(
- GetWidget()->GetRootView());
- tooltip_manager_.reset(manager);
+ if (params.type != Widget::InitParams::TYPE_TOOLTIP) {
+ tooltip_manager_.reset(new views::TooltipManagerAura(this));
}
drop_helper_.reset(new DropHelper(GetWidget()->GetRootView()));
@@ -598,13 +597,11 @@ bool NativeWidgetAura::OnMouseEvent(aura::MouseEvent* event) {
DCHECK(window_->IsVisible());
if (event->type() == ui::ET_MOUSEWHEEL) {
MouseWheelEvent wheel_event(event);
- if (tooltip_manager_.get())
- tooltip_manager_->UpdateForMouseEvent(wheel_event);
return delegate_->OnMouseEvent(wheel_event);
}
MouseEvent mouse_event(event);
if (tooltip_manager_.get())
- tooltip_manager_->UpdateForMouseEvent(mouse_event);
+ tooltip_manager_->UpdateTooltip();
return delegate_->OnMouseEvent(mouse_event);
}
« no previous file with comments | « ui/views/widget/native_widget_aura.h ('k') | ui/views/widget/tooltip_manager_aura.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698