Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 8767002: make ntp apps promo work correctly (Closed)

Created:
9 years ago by Evan Stade
Modified:
9 years ago
Reviewers:
jstritar
CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

make ntp apps promo work correctly when the promo is showing, use the promo link even if the user clicks on the icon rather than the promo button. Additionally, fix the referrer for clicks on the promo button (by using launchApp). BUG=82857 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112601

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/resources/ntp4/apps_page.js View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Evan Stade
this is what I concluded we want after the discussion we had on http://codereview.chromium.org/8505041/
9 years ago (2011-11-30 23:20:21 UTC) #1
jstritar
This lgtm, but are you sure we want to do this? I thought they the ...
9 years ago (2011-12-01 16:03:43 UTC) #2
jstritar
On 2011/12/01 16:03:43, jstritar wrote: > This lgtm, but are you sure we want to ...
9 years ago (2011-12-01 16:06:14 UTC) #3
Evan Stade
I don't think they want to distinguish between the icon and button. They want to ...
9 years ago (2011-12-01 21:39:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/8767002/1
9 years ago (2011-12-01 22:18:43 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-02 02:18:14 UTC) #6
Change committed as 112601

Powered by Google App Engine
This is Rietveld 408576698