Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1756)

Unified Diff: chrome/browser/resources/ntp4/apps_page.js

Issue 8767002: make ntp apps promo work correctly (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/ntp4/apps_page.js
diff --git a/chrome/browser/resources/ntp4/apps_page.js b/chrome/browser/resources/ntp4/apps_page.js
index aff343f09984b9e3874649c2c42460346f41b955..7551b0dc48940d62d38eceafd3c8c967e9cdf1d7 100644
--- a/chrome/browser/resources/ntp4/apps_page.js
+++ b/chrome/browser/resources/ntp4/apps_page.js
@@ -369,6 +369,7 @@ cr.define('ntp4', function() {
this.appsPromoExtras_.querySelector('.apps-promo-heading');
this.appsPromoLink_ =
this.appsPromoExtras_.querySelector('.apps-promo-link');
+ this.appsPromoLink_.addEventListener('click', this.onClick_.bind(this));
this.appsPromoLogo_ = this.ownerDocument.createElement('img');
this.appsPromoLogo_.className = 'apps-promo-logo';
@@ -437,9 +438,7 @@ cr.define('ntp4', function() {
var is_promo = this.appsPromoExtras_ &&
window.getComputedStyle(this.appsPromoExtras_).display != 'none';
var url = !this.appData_.is_webstore ? '' :
- is_promo ? appendParam(this.appsPromoLink_.href,
- 'utm_source',
- 'chrome-ntp-promo') :
+ is_promo ? this.appsPromoLink_.href :
appendParam(this.appData_.url,
'utm_source',
'chrome-ntp-icon');
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698