views::Label should paint borders in the overridden OnPaint() method.

ui/views/controls/label.cc

Index: ui/views/controls/label.cc
diff --git a/ui/views/controls/label.cc b/ui/views/controls/label.cc
index 452322e3d84e803fac221cd15f9c103791e4b84a..a5daf46d177c90add1e1e39a2d33d421c1b384be 100644
--- a/ui/views/controls/label.cc
+++ b/ui/views/controls/label.cc
@@ -313,6 +313,8 @@ void Label::OnPaint(gfx::Canvas* canvas) {
   int flags = 0;
   CalculateDrawStringParams(&paint_text, &text_bounds, &flags);
   PaintText(canvas, paint_text, text_bounds, flags);
+  OnPaintFocusBorder(canvas);

[sky, 2011/12/01 01:02:42]

Do these really need to be after painting the text? I'm wondering if we could
change 309 to View::OnPaint(canvas) to cover all this.
Also, you'll want to check subclasses to make sure they aren't effected.

[varunjain, 2011/12/01 05:12:03]

You are correct that we can just do View::OnPaint() in the beginning. However,
as you prompted, I checked for some subclasses and some are doing fancy stuff
for focus. So I have removed the OnPaintFocusBorder call because views will
otherwise paint its focus border which may fiddle with the subclasses.
OnPaintBorder is ok because views doesnot do anything unless you explicitly set
a border on the view.

+  OnPaintBorder(canvas);
 }
 
 void Label::OnPaintBackground(gfx::Canvas* canvas) {