views::Label should paint borders in the overridden OnPaint() method.

ui/views/controls/label.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/label.h"
 
 #include <algorithm>
 #include <cmath>
 #include <limits>
 #include <vector>
@@ skipping 295 matching lines @@
 }
 
 void Label::OnPaint(gfx::Canvas* canvas) {
   OnPaintBackground(canvas);
 
   string16 paint_text;
   gfx::Rect text_bounds;
   int flags = 0;
   CalculateDrawStringParams(&paint_text, &text_bounds, &flags);
   PaintText(canvas, paint_text, text_bounds, flags);
+  OnPaintFocusBorder(canvas);

[sky, 2011/12/01 01:02:42]

Do these really need to be after painting the text? I'm wondering if we could
change 309 to View::OnPaint(canvas) to cover all this.
Also, you'll want to check subclasses to make sure they aren't effected.

[varunjain, 2011/12/01 05:12:03]

You are correct that we can just do View::OnPaint() in the beginning. However,
as you prompted, I checked for some subclasses and some are doing fancy stuff
for focus. So I have removed the OnPaintFocusBorder call because views will
otherwise paint its focus border which may fiddle with the subclasses.
OnPaintBorder is ok because views doesnot do anything unless you explicitly set
a border on the view.

+  OnPaintBorder(canvas);
 }
 
 void Label::OnPaintBackground(gfx::Canvas* canvas) {
   const Background* bg = contains_mouse_ ? GetMouseOverBackground() : NULL;
   if (!bg)
     bg = background();
   if (bg)
     bg->Paint(canvas, this);
 }
 
@@ skipping 168 matching lines @@
   // it is right aligned. Otherwise, its directionality is forced to be LTR.
   if (rtl_alignment_mode_ == AUTO_DETECT_ALIGNMENT) {
     if (horiz_alignment_ == ALIGN_RIGHT)
       *flags |= gfx::Canvas::FORCE_RTL_DIRECTIONALITY;
     else
       *flags |= gfx::Canvas::FORCE_LTR_DIRECTIONALITY;
   }
 }
 
 }  // namespace views