Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2390)

Unified Diff: content/renderer/media/audio_renderer_impl.cc

Issue 8763010: Replace AudioDecoder::ProduceAudioSamples/ConsumeAudioSamples with read callbacks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: stuff Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/audio_renderer_impl.cc
diff --git a/content/renderer/media/audio_renderer_impl.cc b/content/renderer/media/audio_renderer_impl.cc
index 3e617f549dcd2f12f8e3e465ad0a8e1ef5d2941b..2034d1eb36190708b176b8528a132904a56462f8 100644
--- a/content/renderer/media/audio_renderer_impl.cc
+++ b/content/renderer/media/audio_renderer_impl.cc
@@ -137,20 +137,6 @@ void AudioRendererImpl::NotifyDataAvailableIfNecessary() {
}
}
-void AudioRendererImpl::ConsumeAudioSamples(
scherkus (not reviewing) 2011/12/07 05:25:12 enal: do you recall why this was needed? I tested
enal 2011/12/15 22:51:26 No idea, it was before my time...
- scoped_refptr<media::Buffer> buffer_in) {
- base::AutoLock auto_lock(lock_);
- if (stopped_)
- return;
-
- // TODO(hclam): handle end of stream here.
-
- // Use the base class to queue the buffer.
- AudioRendererBase::ConsumeAudioSamples(buffer_in);
-
- NotifyDataAvailableIfNecessary();
-}
-
void AudioRendererImpl::SetPlaybackRate(float rate) {
DCHECK_LE(0.0f, rate);
@@ -299,7 +285,7 @@ void AudioRendererImpl::OnRequestPacket(AudioBuffersState buffers_state) {
request_buffers_state_ = buffers_state;
}
- // Try to fill in the fulfill the packet request.
+ // Try to fulfill the packet request.
NotifyPacketReadyTask();
}

Powered by Google App Engine
This is Rietveld 408576698