Replace AudioDecoder::ProduceAudioSamples/ConsumeAudioSamples with read callbacks.

content/renderer/media/audio_renderer_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/audio_renderer_impl.h"
 
 #include <math.h>
 
 #include <algorithm>
 
@@ skipping 119 matching lines @@
 
 void AudioRendererImpl::NotifyDataAvailableIfNecessary() {
   if (latency_type_ == kHighLatency) {
     // Post a task to render thread to notify a packet reception.
     ChildProcess::current()->io_message_loop()->PostTask(
         FROM_HERE,
         base::Bind(&AudioRendererImpl::NotifyPacketReadyTask, this));
   }
 }
 
-void AudioRendererImpl::ConsumeAudioSamples(

[scherkus (not reviewing), 2011/12/07 05:25:12]

enal: do you recall why this was needed?

I tested high latency audio path and didn't find a single scenario where this
was actually required.

[enal, 2011/12/15 22:51:26]

No idea, it was before my time...

-    scoped_refptr<media::Buffer> buffer_in) {
-  base::AutoLock auto_lock(lock_);
-  if (stopped_)
-    return;
-
-  // TODO(hclam): handle end of stream here.
-
-  // Use the base class to queue the buffer.
-  AudioRendererBase::ConsumeAudioSamples(buffer_in);
-
-  NotifyDataAvailableIfNecessary();
-}
-
 void AudioRendererImpl::SetPlaybackRate(float rate) {
   DCHECK_LE(0.0f, rate);
 
   base::AutoLock auto_lock(lock_);
   // Handle the case where we stopped due to IO message loop dying.
   if (stopped_) {
     AudioRendererBase::SetPlaybackRate(rate);
     return;
   }
 
@@ skipping 128 matching lines @@
 void AudioRendererImpl::OnRequestPacket(AudioBuffersState buffers_state) {
   DCHECK(MessageLoop::current() == ChildProcess::current()->io_message_loop());
   DCHECK_EQ(kHighLatency, latency_type_);
   {
     base::AutoLock auto_lock(lock_);
     DCHECK(!pending_request_);
     pending_request_ = true;
     request_buffers_state_ = buffers_state;
   }
 
-  // Try to fill in the fulfill the packet request.
+  // Try to fulfill the packet request.
   NotifyPacketReadyTask();
 }
 
 void AudioRendererImpl::OnStateChanged(AudioStreamState state) {
   DCHECK(MessageLoop::current() == ChildProcess::current()->io_message_loop());
 
   base::AutoLock auto_lock(lock_);
   if (stopped_)
     return;
 
@@ skipping 205 matching lines @@
     media::SetActualDataSizeInBytes(shared_memory_.get(),
                                     shared_memory_size_,
                                     size);
     UpdateEarliestEndTime(size, request_delay, time_now);
   }
 }
 
 void AudioRendererImpl::Send(IPC::Message* message) {
   filter_->Send(message);
 }