Issue 8761020: Only create chromeHidden object when needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8761020: Only create chromeHidden object when needed. (Closed)

Created:
9 years ago by Aaron Boodman

Modified:
9 years ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, darin-cc_chromium.org, mihaip+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Only create chromeHidden object when needed. This was less useful than I thought it would be because we are purposely creating chromeHidden for web pages now, due to the chrome.app API. Also, move GetChromeHidden() to ChromeV8Context just because it makes more sense to me there. BUG=106014 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112540

Patch Set 1 #

Patch Set 2 : Move GetChromeHidden to ChromeV8Context #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -42 lines)			Patch
M	chrome/renderer/extensions/chrome_v8_context.h	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	chrome/renderer/extensions/chrome_v8_context.cc	View	1	3 chunks	+43 lines, -2 lines	0 comments	Download
M	chrome/renderer/extensions/chrome_v8_extension.h	View	1	2 chunks	+0 lines, -11 lines	0 comments	Download
M	chrome/renderer/extensions/chrome_v8_extension.cc	View	1	2 chunks	+1 line, -29 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages