Only create chromeHidden object when needed.

chrome/renderer/extensions/chrome_v8_extension.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/chrome_v8_extension.h"
 
 #include "base/logging.h"
 #include "base/lazy_instance.h"
 #include "base/stringprintf.h"
 #include "base/string_util.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_set.h"
 #include "chrome/common/extensions/api/extension_api.h"
 #include "chrome/renderer/extensions/chrome_v8_context.h"
 #include "chrome/renderer/extensions/extension_dispatcher.h"
 #include "content/public/renderer/render_view.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebDocument.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebView.h"
 #include "ui/base/resource/resource_bundle.h"
 
 using extensions::ExtensionAPI;
 using WebKit::WebFrame;
 using WebKit::WebView;
 
 namespace {
 
-const char kChromeHidden[] = "chromeHidden";
-
-#ifndef NDEBUG
-const char kValidateCallbacks[] = "validateCallbacks";
-#endif
-
 static base::LazyInstance<ChromeV8Extension::InstanceSet> g_instances =
     LAZY_INSTANCE_INITIALIZER;
 
 }  // namespace
 
 
 // static
 base::StringPiece ChromeV8Extension::GetStringResource(int resource_id) {
   return ResourceBundle::GetSharedInstance().GetRawDataResource(resource_id);
 }
@@ skipping 147 matching lines @@
   return handler->HandleNativeFunction(name, arguments);
 }
 
 ChromeV8ExtensionHandler* ChromeV8Extension::CreateHandler(
     ChromeV8Context* context) {
   return NULL;
 }
 
 v8::Handle<v8::Value> ChromeV8Extension::GetChromeHidden(
     const v8::Arguments& args) {
-  return GetChromeHidden(v8::Context::GetCurrent());
-}
-
-v8::Handle<v8::Value> ChromeV8Extension::GetChromeHidden(
-    const v8::Handle<v8::Context>& context) {
-  v8::Local<v8::Object> global = context->Global();
-  v8::Local<v8::Value> hidden = global->GetHiddenValue(
-      v8::String::New(kChromeHidden));
-
-  if (hidden.IsEmpty() || hidden->IsUndefined()) {
-    hidden = v8::Object::New();
-    global->SetHiddenValue(v8::String::New(kChromeHidden), hidden);
-
-#ifndef NDEBUG
-    // Tell schema_generated_bindings.js to validate callbacks and events
-    // against their schema definitions in api/extension_api.json.
-    v8::Local<v8::Object>::Cast(hidden)
-        ->Set(v8::String::New(kValidateCallbacks), v8::True());
-#endif
-  }
-
-  DCHECK(hidden->IsObject());
-  return v8::Local<v8::Object>::Cast(hidden);
+  return ChromeV8Context::GetOrCreateChromeHidden(v8::Context::GetCurrent());
 }
 
 v8::Handle<v8::Value> ChromeV8Extension::Print(const v8::Arguments& args) {
   if (args.Length() < 1)
     return v8::Undefined();
 
   std::vector<std::string> components;
   for (int i = 0; i < args.Length(); ++i)
     components.push_back(*v8::String::Utf8Value(args[i]->ToString()));
 
   LOG(ERROR) << JoinString(components, ',');
   return v8::Undefined();
 }