Issue 8761013: Remove the #include of verrsrc.h from mini_installer_version.rc.version. This makes building mini...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8761013: Remove the #include of verrsrc.h from mini_installer_version.rc.version. This makes building mini... (Closed)

Created:
9 years ago by robertshield

Modified:
9 years ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews, Sigurður Ásgeirsson

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove the #include of verrsrc.h from mini_installer_version.rc.version. This makes building mini_installer on platforms with different SDK levels irksome. BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112590

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	chrome/installer/mini_installer/mini_installer_exe_version.rc.version	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/8761013/1

9 years ago (2011-12-01 01:26:03 UTC) #3

commit-bot: I haz the power

The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...

9 years ago (2011-12-01 02:53:17 UTC) #4

commit-bot: I haz the power

9 years ago (2011-12-02 01:10:38 UTC) #5

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/8761013/1

Expand Messages | Collapse Messages