chrome/installer/mini_installer/mini_installer_exe_version.rc.version - Issue 8761013: Remove the #include of verrsrc.h from mini_installer_version.rc.version. This makes building mini...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/mini_installer/mini_installer_exe_version.rc.version

Issue 8761013: Remove the #include of verrsrc.h from mini_installer_version.rc.version. This makes building mini... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/mini_installer/mini_installer_exe_version.rc.version

===================================================================

--- chrome/installer/mini_installer/mini_installer_exe_version.rc.version (revision 112219)

+++ chrome/installer/mini_installer/mini_installer_exe_version.rc.version (working copy)

@@ -2,9 +2,12 @@

// Version

-#include "verrsrc.h"

-VS_VERSION_INFO VERSIONINFO

+// Use the ordinal 1 here, to avoid needing to #include a header file

+// to use the VS_VERSION_INFO macro. This header file changes with different

+// SDK versions which causes headaches building in some environments. The

+// VERSIONINFO resource will always be at index 1.

+1 VERSIONINFO

FILEVERSION @MAJOR@,@MINOR@,@BUILD@,@PATCH@

PRODUCTVERSION @MAJOR@,@MINOR@,@BUILD@,@PATCH@

FILEFLAGSMASK 0x17L

« no previous file with comments | « no previous file | no next file » | no next file with comments »