Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: chrome/common/extensions/extension_process_policy.cc

Issue 8760024: Cross-process postMessage (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Some cleanup Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension_process_policy.cc
diff --git a/chrome/common/extensions/extension_process_policy.cc b/chrome/common/extensions/extension_process_policy.cc
index edadd0f48278c41218b0dfde15cc61c33bd6360c..a7acec0e8a6b40b72a05bee3d6d2de50184158ae 100644
--- a/chrome/common/extensions/extension_process_policy.cc
+++ b/chrome/common/extensions/extension_process_policy.cc
@@ -26,25 +26,6 @@ bool CrossesExtensionProcessBoundary(
const Extension* new_url_extension = GetNonBookmarkAppExtension(extensions,
new_url);
- // TODO(creis): Temporary workaround for crbug.com/59285: Do not swap process
- // to navigate from a hosted app to a normal page or another hosted app
- // (unless either is the web store). This is because we do not yet support
- // postMessage calls from outside the app back into it (e.g., as in Facebook
- // OAuth 2.0). This will be removed when http://crbug.com/99202 is fixed.
- bool old_url_is_hosted_app = old_url_extension &&
- !old_url_extension->web_extent().is_empty();
- bool new_url_is_normal_or_hosted = !new_url_extension ||
- !new_url_extension->web_extent().is_empty();
- bool either_is_web_store =
- (old_url_extension &&
- old_url_extension->id() == extension_misc::kWebStoreAppId) ||
- (new_url_extension &&
- new_url_extension->id() == extension_misc::kWebStoreAppId);
- if (old_url_is_hosted_app &&
- new_url_is_normal_or_hosted &&
- !either_is_web_store)
- return false;
-
return old_url_extension != new_url_extension;
}

Powered by Google App Engine
This is Rietveld 408576698