Cross-process postMessage

chrome/browser/tab_contents/render_view_host_delegate_helper.h

Index: chrome/browser/tab_contents/render_view_host_delegate_helper.h
diff --git a/chrome/browser/tab_contents/render_view_host_delegate_helper.h b/chrome/browser/tab_contents/render_view_host_delegate_helper.h
index 7e0c2fb6af36147bf9081193a2bf4549d908bd03..04444127d86cf6df630511475c4364a6f62a0881 100644
--- a/chrome/browser/tab_contents/render_view_host_delegate_helper.h
+++ b/chrome/browser/tab_contents/render_view_host_delegate_helper.h
@@ -30,6 +30,7 @@ struct ViewHostMsg_CreateWindow_Params;
 
 namespace content {
 class BrowserContext;
+class ContentFrame;
 class RenderProcessHost;
 }
 
@@ -67,7 +68,7 @@ class RenderViewHostDelegateViewHelper : public content::NotificationObserver {
   // These methods are meant to be called from TabContentsView implementations.
   // They take care of notifying the TabContentsDelegate.
   TabContents* CreateNewWindowFromTabContents(

[awong, 2011/12/21 01:06:38]

This function needs to be renamed.

[supersat, 2011/12/23 03:22:46]

Done.

-      TabContents* tab_contents,
+      content::ContentFrame* opener,
       int route_id,
       const ViewHostMsg_CreateWindow_Params& params);
   // Mirrors the RenderViewHostDelegate::View Show methods.
@@ -97,7 +98,7 @@ class RenderViewHostDelegateViewHelper : public content::NotificationObserver {
       Profile* profile,
       SiteInstance* site,
       WebUI::TypeID webui_type,
-      RenderViewHostDelegate* opener,
+      content::ContentFrame* opener,

[awong, 2011/12/21 01:56:07]

The fact that these two APIs take a ContentFrame and return a TabContents makes
me wonder slightly about the relationship between ContentFrame and TabContents.

A ContentFrame is a handle to any WebFrame (top-level of not).

A TabContents seems to be both a handle onto a top-level frame as well as an
anchor point for various bits of navigation data + UI data.

Logically, has the handle to the "top-level" change from being it's TabContents
object to the corresponding ContentFrame object?

[supersat, 2011/12/23 03:22:46]

When the opener TabContents was passed in before, it was only used to copy the
size of the TabContents
(http://google.com/codesearch#OAMlx_jo-ck/src/content/browser/tab_contents/tab...).
Now we're also setting the opener of the top-level ContentFrame in TabContents.
This could be a subframe of another top-level frame, so we need to pass in a
ContentFrame instead. However, we still copy the container size from the
ContentFrame's enclosing TabContents.

       WindowContainerType window_container_type,
       const string16& frame_name);