Cross-process postMessage

chrome/browser/tab_contents/render_view_host_delegate_helper.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_TAB_CONTENTS_RENDER_VIEW_HOST_DELEGATE_HELPER_H_
 #define CHROME_BROWSER_TAB_CONTENTS_RENDER_VIEW_HOST_DELEGATE_HELPER_H_
 #pragma once
 
 #include <map>
 #include <string>
@@ skipping 12 matching lines @@
 class RenderViewHost;
 class RenderViewHostDelegate;
 class RenderWidgetHost;
 class RenderWidgetHostView;
 class SiteInstance;
 class TabContents;
 struct ViewHostMsg_CreateWindow_Params;
 
 namespace content {
 class BrowserContext;
+class ContentFrame;
 class RenderProcessHost;
 }
 
 namespace gfx {
 class Rect;
 }
 
 // Provides helper methods that provide common implementations of some
 // RenderViewHostDelegate::View methods.
 class RenderViewHostDelegateViewHelper : public content::NotificationObserver {
@@ skipping 16 matching lines @@
 
   // Finds the new RenderViewHost/Delegate by route_id, initializes it for
   // for renderer-initiated creation, and returns the TabContents that needs
   // to be shown, if there is one (i.e. not a BackgroundContents). Note that
   // this can only be called once as this call also removes it from the internal
   // map.
   TabContents* GetCreatedWindow(int route_id);
 
   // These methods are meant to be called from TabContentsView implementations.
   // They take care of notifying the TabContentsDelegate.
   TabContents* CreateNewWindowFromTabContents(

[awong, 2011/12/21 01:06:38]

This function needs to be renamed.

[supersat, 2011/12/23 03:22:46]

Done.

-      TabContents* tab_contents,
+      content::ContentFrame* opener,
       int route_id,
       const ViewHostMsg_CreateWindow_Params& params);
   // Mirrors the RenderViewHostDelegate::View Show methods.
   TabContents* ShowCreatedWindow(TabContents* tab_contents,
                                  int route_id,
                                  WindowOpenDisposition disposition,
                                  const gfx::Rect& initial_pos,
                                  bool user_gesture);
   RenderWidgetHostView* ShowCreatedWidget(TabContents* tab_contents,
                                           int route_id,
                                           const gfx::Rect& initial_pos);
   RenderWidgetHostView* ShowCreatedFullscreenWidget(TabContents* tab_contents,
                                                     int route_id);
 
  private:
   // content::NotificationObserver implementation
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
 
   // Creates a new renderer for window.open. This will either be a
   // BackgroundContents (if the window_container_type ==
   // WINDOW_CONTAINER_TYPE_BACKGROUND and permissions allow) or a TabContents.
   // If a TabContents is created, it is returned. Otherwise NULL is returned.
   TabContents* CreateNewWindow(
       int route_id,
       Profile* profile,
       SiteInstance* site,
       WebUI::TypeID webui_type,
-      RenderViewHostDelegate* opener,
+      content::ContentFrame* opener,

[awong, 2011/12/21 01:56:07]

The fact that these two APIs take a ContentFrame and return a TabContents makes
me wonder slightly about the relationship between ContentFrame and TabContents.

A ContentFrame is a handle to any WebFrame (top-level of not).

A TabContents seems to be both a handle onto a top-level frame as well as an
anchor point for various bits of navigation data + UI data.

Logically, has the handle to the "top-level" change from being it's TabContents
object to the corresponding ContentFrame object?

[supersat, 2011/12/23 03:22:46]

When the opener TabContents was passed in before, it was only used to copy the
size of the TabContents
(http://google.com/codesearch#OAMlx_jo-ck/src/content/browser/tab_contents/tab...).
Now we're also setting the opener of the top-level ContentFrame in TabContents.
This could be a subframe of another top-level frame, so we need to pass in a
ContentFrame instead. However, we still copy the container size from the
ContentFrame's enclosing TabContents.

       WindowContainerType window_container_type,
       const string16& frame_name);
 
   BackgroundContents* MaybeCreateBackgroundContents(
       int route_id,
       Profile* profile,
       SiteInstance* site,
       const GURL& opener_url,
       const string16& frame_name);
 
@@ skipping 25 matching lines @@
                                      const std::string& value);
   static void ClearInspectorSettings(content::BrowserContext* browser_context);
 
  private:
   RenderViewHostDelegateHelper();
 
   DISALLOW_COPY_AND_ASSIGN(RenderViewHostDelegateHelper);
 };
 
 #endif  // CHROME_BROWSER_TAB_CONTENTS_RENDER_VIEW_HOST_DELEGATE_HELPER_H_