Issue 8758017: aura: fix fullscreen pepper flash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8758017: aura: fix fullscreen pepper flash (Closed)

Created:
9 years ago by piman

Modified:
9 years ago

Reviewers:
Ben Goodger (Google), jonathan.backer

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, dpranke-watch+content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

aura: fix fullscreen pepper flash 2 parts: - not all RenderWidgetHosts are RenderViewHosts - correctly set window/viewport size regardless of order of RenderWidgetFullscreenPepper::OnResize vs RenderWidgetFullscreenPepper::CreateContext BUG=101848 TEST=Pepper Flash on Youtube, go fullscreen Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112503

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -28 lines)			Patch
	M	content/browser/gpu/gpu_process_host_ui_shim.cc	View		6 chunks	+22 lines, -28 lines	0 comments	Download
	M	content/renderer/render_widget_fullscreen_pepper.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

piman

backer: please review ben: OWNERS Note: it needs http://codereview.chromium.org/8760018/ to fully work (otherwise you only ...

9 years ago (2011-12-01 04:34:27 UTC) #1

Ben Goodger (Google)

lgtm2 On Thu, Dec 1, 2011 at 5:32 AM, <backer@chromium.org> wrote: > lgtm > > ...

9 years ago (2011-12-01 16:12:58 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/8758017/1

9 years ago (2011-12-01 18:20:41 UTC) #4

Change committed as 112503

Expand Messages | Collapse Messages