Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 8758004: Handle exceptions thrown when shelling out the editor (Closed)

Created:
9 years ago by M-A Ruel
Modified:
9 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke
Visibility:
Public.

Description

Handle exceptions thrown when shelling out svn commit So temporary files aren't left around. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112358

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M gcl.py View 1 chunk +19 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
9 years ago (2011-11-30 21:44:08 UTC) #1
Dirk Pranke
change looks fine, but your description is wrong, isn't it? this is shelling out to ...
9 years ago (2011-11-30 22:09:18 UTC) #2
M-A Ruel
On 2011/11/30 22:09:18, Dirk Pranke wrote: > change looks fine, but your description is wrong, ...
9 years ago (2011-12-01 00:35:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8758004/2001
9 years ago (2011-12-01 00:36:20 UTC) #4
commit-bot: I haz the power
9 years ago (2011-12-01 00:42:57 UTC) #5
Change committed as 112358

Powered by Google App Engine
This is Rietveld 408576698