Handle exceptions thrown when shelling out the editor

gcl.py

 #!/usr/bin/env python
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """\
 Wrapper script around Rietveld's upload.py that simplifies working with groups
 of files.
 """
 
@@ skipping 982 matching lines @@
   commit_message = change_info.description.replace('\r\n', '\n')
   if change_info.issue:
     server = change_info.rietveld
     if not server.startswith("http://") and not server.startswith("https://"):
       server = "http://" + server
     commit_message += ('\nReview URL: %s/%d' % (server, change_info.issue))
 
   handle, commit_filename = tempfile.mkstemp(text=True)
   os.write(handle, commit_message)
   os.close(handle)
-
-  handle, targets_filename = tempfile.mkstemp(text=True)
-  os.write(handle, "\n".join(change_info.GetFileNames()))
-  os.close(handle)
-
-  commit_cmd += ['--file=' + commit_filename]
-  commit_cmd += ['--targets=' + targets_filename]
-  # Change the current working directory before calling commit.
-  previous_cwd = os.getcwd()
-  os.chdir(change_info.GetLocalRoot())
-  output = RunShell(commit_cmd, True)
-  os.remove(commit_filename)
-  os.remove(targets_filename)
+  try:
+    handle, targets_filename = tempfile.mkstemp(text=True)
+    os.write(handle, "\n".join(change_info.GetFileNames()))
+    os.close(handle)
+    try:
+      commit_cmd += ['--file=' + commit_filename]
+      commit_cmd += ['--targets=' + targets_filename]
+      # Change the current working directory before calling commit.
+      previous_cwd = os.getcwd()
+      os.chdir(change_info.GetLocalRoot())
+      output = ''
+      try:
+        output = RunShell(commit_cmd, True)
+      except subprocess2.CalledProcessError, e:
+        ErrorExit('Commit failed.\n%s' % e)
+    finally:
+      os.remove(commit_filename)
+  finally:
+    os.remove(targets_filename)
   if output.find("Committed revision") != -1:
     change_info.Delete()
 
     if change_info.issue:
       revision = re.compile(".*?\nCommitted revision (\d+)",
                             re.DOTALL).match(output).group(1)
       viewvc_url = GetCodeReviewSetting("VIEW_VC")
       change_info.description += '\n'
       if viewvc_url:
         change_info.description += "\nCommitted: " + viewvc_url + revision
@@ skipping 412 matching lines @@
       raise
     print >> sys.stderr, (
         'AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
         'and retry or visit go/isgaeup.\n%s') % (e.code, str(e))
     return 1
 
 
 if __name__ == "__main__":
   fix_encoding.fix_encoding()
   sys.exit(main(sys.argv[1:]))