Issue 8757014: Move GetProcessTypeNameInEnglish beside the ProcessType enum where it belongs. This also helps re...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8757014: Move GetProcessTypeNameInEnglish beside the ProcessType enum where it belongs. This also helps re... (Closed)

Created:
9 years ago by jam

Modified:
9 years ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, kkania, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., robertshield

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move GetProcessTypeNameInEnglish beside the ProcessType enum where it belongs. This also helps reduce the dependencies on child_process_info.h from chrome, in preparation for removing the class altogether. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112408

Patch Set 1 #

Patch Set 2 : add the cc file #

Patch Set 3 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -50 lines)			Patch
M	chrome/browser/automation/automation_provider_observers.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/automation/testing_automation_provider.cc	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/memory_details.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/metrics/tracking_synchronizer.cc	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/common/child_process_info.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/common/child_process_info.cc	View		1 chunk	+0 lines, -37 lines	0 comments	Download
A	content/common/process_type.cc	View	1	1 chunk	+46 lines, -0 lines	0 comments	Download
M	content/content_common.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/common/process_type.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

Did you miss the implementation file from this patch? Where is GetProcessTypeNameInEnglish() defined?

9 years ago (2011-12-01 02:54:22 UTC) #2

jam

On 2011/12/01 02:54:22, Dirk Pranke wrote: > Did you miss the implementation file from this ...

9 years ago (2011-12-01 02:58:18 UTC) #3

(got verbal lgtm from Dirk)

Expand Messages | Collapse Messages