Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: content/common/child_process_info.cc

Issue 8757014: Move GetProcessTypeNameInEnglish beside the ProcessType enum where it belongs. This also helps re... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/child_process_info.h ('k') | content/common/process_type.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/child_process_info.cc
===================================================================
--- content/common/child_process_info.cc (revision 112374)
+++ content/common/child_process_info.cc (working copy)
@@ -45,43 +45,6 @@
return *this;
}
-// static
-std::string ChildProcessInfo::GetTypeNameInEnglish(
- content::ProcessType type) {
- switch (type) {
- case content::PROCESS_TYPE_BROWSER:
- return "Browser";
- case content::PROCESS_TYPE_RENDERER:
- return "Tab";
- case content::PROCESS_TYPE_PLUGIN:
- return "Plug-in";
- case content::PROCESS_TYPE_WORKER:
- return "Web Worker";
- case content::PROCESS_TYPE_UTILITY:
- return "Utility";
- case content::PROCESS_TYPE_PROFILE_IMPORT:
- return "Profile Import helper";
- case content::PROCESS_TYPE_ZYGOTE:
- return "Zygote";
- case content::PROCESS_TYPE_SANDBOX_HELPER:
- return "Sandbox helper";
- case content::PROCESS_TYPE_NACL_LOADER:
- return "Native Client module";
- case content::PROCESS_TYPE_NACL_BROKER:
- return "Native Client broker";
- case content::PROCESS_TYPE_GPU:
- return "GPU";
- case content::PROCESS_TYPE_PPAPI_PLUGIN:
- return "Pepper Plugin";
- case content::PROCESS_TYPE_PPAPI_BROKER:
- return "Pepper Plugin Broker";
- case content::PROCESS_TYPE_UNKNOWN:
- default:
- DCHECK(false) << "Unknown child process type!";
- return "Unknown";
- }
-}
-
std::string ChildProcessInfo::GenerateRandomChannelID(void* instance) {
// Note: the string must start with the current process id, this is how
// child processes determine the pid of the parent.
« no previous file with comments | « content/common/child_process_info.h ('k') | content/common/process_type.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698