Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 8756001: Rebind to correct backbuffer after clearing READ buffer. (Closed)

Created:
9 years ago by greggman
Modified:
9 years ago
Reviewers:
jbates
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Rebind to correct backbuffer after clearing READ buffer. BUG=none TEST=unit tests R=jbates@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112394

Patch Set 1 #

Patch Set 2 : add unit test #

Total comments: 2

Patch Set 3 : remove unused result #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -22 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 1 chunk +5 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 1 chunk +31 lines, -18 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 2 chunks +45 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
greggman
Hey John, Do you mind reviewing this? Al is out.
9 years ago (2011-11-30 21:16:31 UTC) #1
jbates
LGTM, one question http://codereview.chromium.org/8756001/diff/2001/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc File gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc (right): http://codereview.chromium.org/8756001/diff/2001/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc#newcode5510 gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc:5510: Result* result = GetSharedMemoryAs<Result*>(); It doesn't ...
9 years ago (2011-11-30 22:00:50 UTC) #2
greggman
http://codereview.chromium.org/8756001/diff/2001/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc File gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc (right): http://codereview.chromium.org/8756001/diff/2001/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc#newcode5510 gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc:5510: Result* result = GetSharedMemoryAs<Result*>(); On 2011/11/30 22:00:51, jbates wrote: ...
9 years ago (2011-11-30 22:13:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/8756001/5002
9 years ago (2011-12-01 01:17:02 UTC) #4
commit-bot: I haz the power
9 years ago (2011-12-01 04:25:49 UTC) #5
Change committed as 112394

Powered by Google App Engine
This is Rietveld 408576698