Maximize windows when double clicking their title bar.

Maximize windows when double clicking their title bar.

Note that this won't work on Linux until we crack double clicks from XEvents.

BUG=none
TEST=unit tests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112338

[oshima, 2011-11-30 22:31:08]

http://codereview.chromium.org/8755003/diff/2001/ui/aura/test/event_generator.cc
File ui/aura/test/event_generator.cc (right):

http://codereview.chromium.org/8755003/diff/2001/ui/aura/test/event_generator...
ui/aura/test/event_generator.cc:64: Dispatch(event);
I think we need to to generate release event as well and EF_IS_DOUBLE_CLICK
needs to be reset so that next press event doesn't become double click event.

How about

flags_ = ui::EF_IS_DOUBLE_CLICK;
ClickLeftButton();
flags_ ^= ui::EF_IS_DOUBLE_CLICK;

?

[Ben Goodger (Google), 2011-11-30 22:42:45]

http://codereview.chromium.org/8755003/diff/7001/ui/aura/test/event_generator.cc
File ui/aura/test/event_generator.cc (right):

http://codereview.chromium.org/8755003/diff/7001/ui/aura/test/event_generator...
ui/aura/test/event_generator.cc:64: flags_ ^= ui::EF_IS_DOUBLE_CLICK;
Good idea. This is similar to what you propose, but I reset the flags before
sending the release, since the semantics for Windows' DBLCLK processing are:

WM_LBUTTONDOWN
WM_LBUTTONUP
..
WM_LBUTTONDBLCLK  <-- sent in place of second DOWN
WM_LBUTTONUP <-- no double-click metadata.

[oshima, 2011-11-30 22:56:10]

LGTM