Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4483)

Unified Diff: chrome/service/service_child_process_host.h

Issue 8755002: Don't make ServiceChildProcessHost derive from ChildProcessInfo. It didn't really need to. This i... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix posix Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/service/service_child_process_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/service/service_child_process_host.h
===================================================================
--- chrome/service/service_child_process_host.h (revision 112096)
+++ chrome/service/service_child_process_host.h (working copy)
@@ -8,20 +8,19 @@
#include "base/process.h"
#include "content/common/child_process_host.h"
-#include "content/common/child_process_info.h"
class CommandLine;
// Plugins/workers and other child processes that live on the IO thread should
// derive from this class.
//
-class ServiceChildProcessHost : public ChildProcessHost,
- public ChildProcessInfo {
+class ServiceChildProcessHost : public ChildProcessHost {
public:
virtual ~ServiceChildProcessHost();
protected:
- explicit ServiceChildProcessHost(ProcessType type);
+ ServiceChildProcessHost();
+
// Derived classes call this to launch the child process synchronously.
// TODO(sanjeevr): Determine whether we need to make the launch asynchronous.
// |exposed_dir| is the path to tbe exposed to the sandbox. This is ignored
@@ -29,6 +28,13 @@
bool Launch(CommandLine* cmd_line,
bool no_sandbox,
const FilePath& exposed_dir);
+
+ base::ProcessHandle handle() const { return handle_; }
+
+ private:
+ base::ProcessHandle handle_;
+
+ DISALLOW_COPY_AND_ASSIGN(ServiceChildProcessHost);
};
#endif // CHROME_SERVICE_SERVICE_CHILD_PROCESS_HOST_H_
« no previous file with comments | « no previous file | chrome/service/service_child_process_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698