Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: chrome/service/service_child_process_host.h

Issue 8755002: Don't make ServiceChildProcessHost derive from ChildProcessInfo. It didn't really need to. This i... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix posix Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/service/service_child_process_host.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_SERVICE_SERVICE_CHILD_PROCESS_HOST_H_ 5 #ifndef CHROME_SERVICE_SERVICE_CHILD_PROCESS_HOST_H_
6 #define CHROME_SERVICE_SERVICE_CHILD_PROCESS_HOST_H_ 6 #define CHROME_SERVICE_SERVICE_CHILD_PROCESS_HOST_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/process.h" 9 #include "base/process.h"
10 #include "content/common/child_process_host.h" 10 #include "content/common/child_process_host.h"
11 #include "content/common/child_process_info.h"
12 11
13 class CommandLine; 12 class CommandLine;
14 13
15 // Plugins/workers and other child processes that live on the IO thread should 14 // Plugins/workers and other child processes that live on the IO thread should
16 // derive from this class. 15 // derive from this class.
17 // 16 //
18 class ServiceChildProcessHost : public ChildProcessHost, 17 class ServiceChildProcessHost : public ChildProcessHost {
19 public ChildProcessInfo {
20 public: 18 public:
21 virtual ~ServiceChildProcessHost(); 19 virtual ~ServiceChildProcessHost();
22 20
23 protected: 21 protected:
24 explicit ServiceChildProcessHost(ProcessType type); 22 ServiceChildProcessHost();
23
25 // Derived classes call this to launch the child process synchronously. 24 // Derived classes call this to launch the child process synchronously.
26 // TODO(sanjeevr): Determine whether we need to make the launch asynchronous. 25 // TODO(sanjeevr): Determine whether we need to make the launch asynchronous.
27 // |exposed_dir| is the path to tbe exposed to the sandbox. This is ignored 26 // |exposed_dir| is the path to tbe exposed to the sandbox. This is ignored
28 // if |no_sandbox| is true. 27 // if |no_sandbox| is true.
29 bool Launch(CommandLine* cmd_line, 28 bool Launch(CommandLine* cmd_line,
30 bool no_sandbox, 29 bool no_sandbox,
31 const FilePath& exposed_dir); 30 const FilePath& exposed_dir);
31
32 base::ProcessHandle handle() const { return handle_; }
33
34 private:
35 base::ProcessHandle handle_;
36
37 DISALLOW_COPY_AND_ASSIGN(ServiceChildProcessHost);
32 }; 38 };
33 39
34 #endif // CHROME_SERVICE_SERVICE_CHILD_PROCESS_HOST_H_ 40 #endif // CHROME_SERVICE_SERVICE_CHILD_PROCESS_HOST_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/service/service_child_process_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698