Issue 8755002: Don't make ServiceChildProcessHost derive from ChildProcessInfo. It didn't really need to. This i...

Issue 8755002: Don't make ServiceChildProcessHost derive from ChildProcessInfo. It didn't really need to. This i... (Closed)

Created:
9 years ago by jam

Modified:
9 years ago

Reviewers:
sanjeevr, Scott Byer

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Don't make ServiceChildProcessHost derive from ChildProcessInfo. It didn't really need to. This is needed since code in chrome will only be able to see interfaces from content's public API. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112312

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix posix #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -17 lines)			Patch
M	chrome/service/service_child_process_host.h	View		2 chunks	+10 lines, -4 lines	0 comments	Download
M	chrome/service/service_child_process_host.cc	View		2 chunks	+6 lines, -7 lines	0 comments	Download
M	chrome/service/service_utility_process_host.cc	View	1	3 chunks	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Scott Byer

LGTM w/ nit http://codereview.chromium.org/8755002/diff/1/chrome/service/service_utility_process_host.cc File chrome/service/service_utility_process_host.cc (right): http://codereview.chromium.org/8755002/diff/1/chrome/service/service_utility_process_host.cc#newcode24 chrome/service/service_utility_process_host.cc:24: #include "content/common/child_process_info.h" nit: include order

9 years ago (2011-11-30 20:48:33 UTC) #3

jam

http://codereview.chromium.org/8755002/diff/1/chrome/service/service_utility_process_host.cc File chrome/service/service_utility_process_host.cc (right): http://codereview.chromium.org/8755002/diff/1/chrome/service/service_utility_process_host.cc#newcode24 chrome/service/service_utility_process_host.cc:24: #include "content/common/child_process_info.h" On 2011/11/30 20:48:33, Scott Byer wrote: > ...

9 years ago (2011-11-30 20:54:20 UTC) #4

Scott Byer

9 years ago (2011-11-30 21:02:56 UTC) #5

On 2011/11/30 20:54:20, John Abd-El-Malek wrote:
>
http://codereview.chromium.org/8755002/diff/1/chrome/service/service_utility_...
> File chrome/service/service_utility_process_host.cc (right):
> 
>
http://codereview.chromium.org/8755002/diff/1/chrome/service/service_utility_...
> chrome/service/service_utility_process_host.cc:24: #include
> "content/common/child_process_info.h"
> On 2011/11/30 20:48:33, Scott Byer wrote:
> > nit: include order
> 
> ?
Crossed paths inemail:

Expand Messages | Collapse Messages