Make text input type and password visibility bit independent in Textfield

ui/views/controls/textfield/textfield.h

Index: ui/views/controls/textfield/textfield.h
diff --git a/ui/views/controls/textfield/textfield.h b/ui/views/controls/textfield/textfield.h
index abdd5901ebe787e24533d35130de3281a128420e..eaf9c997f6e5e683d89c3b3395a2048451252e6f 100644
--- a/ui/views/controls/textfield/textfield.h
+++ b/ui/views/controls/textfield/textfield.h
@@ -63,12 +63,11 @@ class VIEWS_EXPORT Textfield : public View {
   bool read_only() const { return read_only_; }
   void SetReadOnly(bool read_only);
 
-  // Gets/Sets whether or not this Textfield is a password field.
-  // TODO(bryeung): Currently this is only used in
-  // chrome/browser/chromeos/options/wifi_config_view.cc, which is being
-  // converted to WebUI.  Please remove this when that happens.
-  bool IsPassword() const;
-  void SetPassword(bool password);
+  // Gets whether or not this Textfield is a password field. This property
+  // can be set by calling SetTextInputType.
+  bool IsPassword() const {
+    return style() & STYLE_PASSWORD;

[tfarina, 2011/11/30 19:32:03]

nit: please use style_ here directly. Also I'd prefer if you could move this
implementation to the source file instead (avoid polluting the header file with
implementation details).

[benrg, 2011/11/30 19:54:24]

This was one of my bullet points -- I wanted to make it clear that this method
isn't primitive (I was toying with the idea of removing it). If you still think
it's better as an implementation detail, I'll move it back.

[oshima, 2011/12/01 22:08:22]

This one should be in .cc

[benrg, 2011/12/01 23:36:16]

Done.

+  }
 
   // Gets/Sets the input type of this textfield.
   ui::TextInputType GetTextInputType() const;