Make text input type and password visibility bit independent in Textfield

ui/views/controls/textfield/textfield.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_
 #define UI_VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_
 #pragma once
 
 #include "build/build_config.h"
 
@@ skipping 45 matching lines @@
   virtual ~Textfield();
 
   // TextfieldController accessors
   void SetController(TextfieldController* controller);
   TextfieldController* GetController() const;
 
   // Gets/Sets whether or not the Textfield is read-only.
   bool read_only() const { return read_only_; }
   void SetReadOnly(bool read_only);
 
-  // Gets/Sets whether or not this Textfield is a password field.
-  // TODO(bryeung): Currently this is only used in
-  // chrome/browser/chromeos/options/wifi_config_view.cc, which is being
-  // converted to WebUI.  Please remove this when that happens.
-  bool IsPassword() const;
-  void SetPassword(bool password);
+  // Gets whether or not this Textfield is a password field. This property
+  // can be set by calling SetTextInputType.
+  bool IsPassword() const {
+    return style() & STYLE_PASSWORD;

[tfarina, 2011/11/30 19:32:03]

nit: please use style_ here directly. Also I'd prefer if you could move this
implementation to the source file instead (avoid polluting the header file with
implementation details).

[benrg, 2011/11/30 19:54:24]

This was one of my bullet points -- I wanted to make it clear that this method
isn't primitive (I was toying with the idea of removing it). If you still think
it's better as an implementation detail, I'll move it back.

[oshima, 2011/12/01 22:08:22]

This one should be in .cc

[benrg, 2011/12/01 23:36:16]

Done.

+  }
 
   // Gets/Sets the input type of this textfield.
   ui::TextInputType GetTextInputType() const;
   void SetTextInputType(ui::TextInputType type);
 
   // Gets/Sets the text currently displayed in the Textfield.
   const string16& text() const { return text_; }
 
   // Sets the text currently displayed in the Textfield.  This doesn't
   // change the cursor position if the current cursor is within the
@@ skipping 224 matching lines @@
 
   // The input type of this text field.
   ui::TextInputType text_input_type_;
 
   DISALLOW_COPY_AND_ASSIGN(Textfield);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_