chrome/browser/ui/views/login_view.cc - Issue 8748001: Make text input type and password visibility bit independent in Textfield

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/login_view.cc

Issue 8748001: Make text input type and password visibility bit independent in Textfield (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Textfield(STYLE_OBSCURED) sets TEXT_INPUT_TYPE_PASSWORD Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/crypto_module_password_dialog_view.cc ('k') | ui/gfx/render_text.h » ('j') | ui/views/controls/textfield/native_textfield_gtk.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/login_view.cc

diff --git a/chrome/browser/ui/views/login_view.cc b/chrome/browser/ui/views/login_view.cc

index 3804376a212e88eb5e38c90551770fc61cdc28ed..3354b11db092b5dc0fa9289b1b4a12f60e0db244 100644

--- a/chrome/browser/ui/views/login_view.cc

+++ b/chrome/browser/ui/views/login_view.cc

@@ -27,7 +27,7 @@ using views::GridLayout;

LoginView::LoginView(const std::wstring& explanation, LoginModel* model)

: username_field_(new views::Textfield),

- password_field_(new views::Textfield(views::Textfield::STYLE_PASSWORD)),

+ password_field_(new views::Textfield(views::Textfield::STYLE_OBSCURED)),

username_label_(new views::Label(

l10n_util::GetStringUTF16(IDS_LOGIN_DIALOG_USERNAME_FIELD))),

password_label_(new views::Label(