Apply per-tab preference after RenderViewImpl creation.

chrome/browser/ui/tab_contents/tab_contents_wrapper.h

Index: chrome/browser/ui/tab_contents/tab_contents_wrapper.h
diff --git a/chrome/browser/ui/tab_contents/tab_contents_wrapper.h b/chrome/browser/ui/tab_contents/tab_contents_wrapper.h
index f912cf3022fb433d43d6f4006ce1354e94a8b148..af29f512c70ee209076938316330e38a72e94b9e 100644
--- a/chrome/browser/ui/tab_contents/tab_contents_wrapper.h
+++ b/chrome/browser/ui/tab_contents/tab_contents_wrapper.h
@@ -236,6 +236,8 @@ class TabContentsWrapper : public TabContentsObserver,
                        const content::NotificationDetails& details) OVERRIDE;
 
  private:
+  friend class PerTabPrefsTabHelper;  // for UpdateWebPreferences

[Avi (use Gerrit), 2011/11/30 15:15:18]

This doesn't make me happy, but I'm not sure I have a choice.

Right now the TCW handles preferences, and that should be its job. In an ideal
world there would be a pref tab helper that would handle all the preference
stuff, both what TCW does now and the per-tab stuff. But that's probably going
to have to wait until I can attack it.

[mnaganov (inactive), 2011/11/30 15:19:35]

An alternative arrangement is to put a call to UpdateWebPreferences into
TabContentsWrapper::RenderViewCreated. This will eliminate the need for
introducing friendship. To me, handling this in PerTabPrefsHelper is more
logical because these are overridden settings that need to be updated.

+
   // Internal helpers ----------------------------------------------------------
 
   // Message handlers.