Apply per-tab preference after RenderViewImpl creation.

chrome/browser/ui/tab_contents/tab_contents_wrapper.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_
 #define CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 218 matching lines @@
   virtual void DidBecomeSelected() OVERRIDE;
   virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
   virtual void TabContentsDestroyed(TabContents* tab) OVERRIDE;
 
   // content::NotificationObserver overrides:
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
 
  private:
+  friend class PerTabPrefsTabHelper;  // for UpdateWebPreferences

[Avi (use Gerrit), 2011/11/30 15:15:18]

This doesn't make me happy, but I'm not sure I have a choice.

Right now the TCW handles preferences, and that should be its job. In an ideal
world there would be a pref tab helper that would handle all the preference
stuff, both what TCW does now and the per-tab stuff. But that's probably going
to have to wait until I can attack it.

[mnaganov (inactive), 2011/11/30 15:19:35]

An alternative arrangement is to put a call to UpdateWebPreferences into
TabContentsWrapper::RenderViewCreated. This will eliminate the need for
introducing friendship. To me, handling this in PerTabPrefsHelper is more
logical because these are overridden settings that need to be updated.

+
   // Internal helpers ----------------------------------------------------------
 
   // Message handlers.
   void OnSnapshot(const SkBitmap& bitmap);
   void OnPDFHasUnsupportedFeature();
 
   // Returns the server that can provide alternate error pages.  If the returned
   // URL is empty, the default error page built into WebKit will be used.
   GURL GetAlternateErrorPageURL() const;
 
@@ skipping 92 matching lines @@
 
   // The supporting objects need to outlive the TabContents dtor (as they may
   // be called upon during its execution). As a result, this must come last
   // in the list.
   scoped_ptr<TabContents> tab_contents_;
 
   DISALLOW_COPY_AND_ASSIGN(TabContentsWrapper);
 };
 
 #endif  // CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_