Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Unified Diff: ui/views/controls/textfield/textfield_views_model_unittest.cc

Issue 8747001: Reintroduce password support to NativeTextfieldViews (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rerebase Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/textfield/textfield_views_model_unittest.cc
diff --git a/ui/views/controls/textfield/textfield_views_model_unittest.cc b/ui/views/controls/textfield/textfield_views_model_unittest.cc
index 643be1f94f877d6a205419900195071885366774..66f4322ea049ca615ec2d5aa5bd540abfc5c9d3d 100644
--- a/ui/views/controls/textfield/textfield_views_model_unittest.cc
+++ b/ui/views/controls/textfield/textfield_views_model_unittest.cc
@@ -244,7 +244,6 @@ TEST_F(TextfieldViewsModelTest, EmptyString) {
TextfieldViewsModel model(NULL);
EXPECT_EQ(string16(), model.GetText());
EXPECT_EQ(string16(), model.GetSelectedText());
- EXPECT_EQ(string16(), model.GetVisibleText());
model.MoveCursorLeft(gfx::CHARACTER_BREAK, true);
EXPECT_EQ(0U, model.GetCursorPosition());
@@ -414,27 +413,6 @@ TEST_F(TextfieldViewsModelTest, SelectionAndEdit) {
EXPECT_STR_EQ("BEE", model.GetText());
}
-TEST_F(TextfieldViewsModelTest, Password) {
- TextfieldViewsModel model(NULL);
- model.set_is_password(true);
- model.Append(ASCIIToUTF16("HELLO"));
- EXPECT_STR_EQ("*****", model.GetVisibleText());
- EXPECT_STR_EQ("HELLO", model.GetText());
- EXPECT_TRUE(model.Delete());
-
- EXPECT_STR_EQ("****", model.GetVisibleText());
- EXPECT_STR_EQ("ELLO", model.GetText());
- EXPECT_EQ(0U, model.GetCursorPosition());
-
- model.SelectAll();
- EXPECT_STR_EQ("ELLO", model.GetSelectedText());
- EXPECT_EQ(4U, model.GetCursorPosition());
-
- model.InsertChar('X');
- EXPECT_STR_EQ("*", model.GetVisibleText());
- EXPECT_STR_EQ("X", model.GetText());
-}
-
TEST_F(TextfieldViewsModelTest, Word) {
TextfieldViewsModel model(NULL);
model.Append(
@@ -479,7 +457,7 @@ TEST_F(TextfieldViewsModelTest, Word) {
EXPECT_STR_EQ("The answer to Life", model.GetSelectedText());
model.ReplaceChar('4');
EXPECT_EQ(string16(), model.GetSelectedText());
- EXPECT_STR_EQ("42", model.GetVisibleText());
+ EXPECT_STR_EQ("42", model.GetText());
}
TEST_F(TextfieldViewsModelTest, SetText) {
« ui/gfx/render_text_unittest.cc ('K') | « ui/views/controls/textfield/textfield_views_model.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698