Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: ui/views/controls/textfield/textfield_views_model.cc

Issue 8747001: Reintroduce password support to NativeTextfieldViews (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rerebase Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/textfield/textfield_views_model.cc
diff --git a/ui/views/controls/textfield/textfield_views_model.cc b/ui/views/controls/textfield/textfield_views_model.cc
index 0895f918cd3140c31f265c08be0e7363e5744c55..d6fbd1d4b9ca3a4d7eb040e682c46435f2499e91 100644
--- a/ui/views/controls/textfield/textfield_views_model.cc
+++ b/ui/views/controls/textfield/textfield_views_model.cc
@@ -277,7 +277,6 @@ TextfieldViewsModel::Delegate::~Delegate() {
TextfieldViewsModel::TextfieldViewsModel(Delegate* delegate)
: delegate_(delegate),
render_text_(gfx::RenderText::CreateRenderText()),
- is_password_(false),
current_edit_(edit_history_.end()) {
}
@@ -501,10 +500,6 @@ bool TextfieldViewsModel::Redo() {
return old != GetText() || old_cursor != GetCursorPosition();
}
-string16 TextfieldViewsModel::GetVisibleText() const {
- return GetVisibleText(0U, GetText().length());
-}
-
bool TextfieldViewsModel::Cut() {
if (!HasCompositionText() && HasSelection()) {
ui::ScopedClipboardWriter(views::ViewsDelegate::views_delegate
@@ -639,13 +634,6 @@ bool TextfieldViewsModel::HasCompositionText() const {
/////////////////////////////////////////////////////////////////
// TextfieldViewsModel: private
-string16 TextfieldViewsModel::GetVisibleText(size_t begin, size_t end) const {
- DCHECK(end >= begin);
- if (is_password_)
- return string16(end - begin, '*');
- return GetText().substr(begin, end - begin);
-}
-
void TextfieldViewsModel::InsertTextInternal(const string16& text,
bool mergeable) {
if (HasCompositionText()) {

Powered by Google App Engine
This is Rietveld 408576698