Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4831)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 8745020: Don't select a client certs for TabContents with no TabContentsWrapper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: " Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 630d9b96c1c3a260587fabdd4dc8408bdcc73dd7..4bdb72724ec0e33ca68bab2fe43fc1dceceb7199 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -856,7 +856,11 @@ void ChromeContentBrowserClient::SelectClientCertificate(
TabContentsWrapper* wrapper =
TabContentsWrapper::GetCurrentWrapperForContents(tab);
- wrapper->ssl_helper()->SelectClientCertificate(handler);
+ if (wrapper) {
Mattias Nissler (ping if slow) 2011/11/30 19:56:16 no need for curlies here.
markusheintz_ 2011/12/02 14:54:20 I think the style guide is ok with that if you hav
markusheintz_ 2011/12/02 14:54:20 I guess the style quide is fine with that.
+ wrapper->ssl_helper()->SelectClientCertificate(handler);
+ } else {
+ handler->CertificateSelected(NULL);
wtc 2011/11/30 23:59:43 It seems that what we do in this case should match
markusheintz_ 2011/12/02 14:54:20 What happens to the request if we don't call Certi
+ }
}
void ChromeContentBrowserClient::AddNewCertificate(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698