Don't select a client certs for TabContents with no TabContentsWrapper.

chrome/browser/chrome_content_browser_client.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_content_browser_client.h"
 
 #include <set>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 838 matching lines @@
     SSLClientAuthHandler* handler) {
   TabContents* tab = tab_util::GetTabContentsByID(
       render_process_id, render_view_id);
   if (!tab) {
     NOTREACHED();
     return;
   }
 
   TabContentsWrapper* wrapper =
       TabContentsWrapper::GetCurrentWrapperForContents(tab);
-  wrapper->ssl_helper()->SelectClientCertificate(handler);
+  if (wrapper) {

[Mattias Nissler (ping if slow), 2011/11/30 19:56:16]

no need for curlies here.

[markusheintz_, 2011/12/02 14:54:20]

I think the style guide is ok with that if you have an else. 

[markusheintz_, 2011/12/02 14:54:20]

I guess the style quide is fine with that.

+    wrapper->ssl_helper()->SelectClientCertificate(handler);
+  } else {
+    handler->CertificateSelected(NULL);

[wtc, 2011/11/30 23:59:43]

It seems that what we do in this case should match what we
do above on lines 853-854 if |tab| is NULL.

[markusheintz_, 2011/12/02 14:54:20]

What happens to the request if we don't call CertificateSelected(NULL) on the
handler? Does it have to time out?

I can not add a NOTREACHED, this would crash chrome every time a background page
of an extension send a xhr to a site that requests a client cert.

+  }
 }
 
 void ChromeContentBrowserClient::AddNewCertificate(
     net::URLRequest* request,
     net::X509Certificate* cert,
     int render_process_id,
     int render_view_id) {
   // The handler will run the UI and delete itself when it's finished.
   new SSLAddCertHandler(request, cert, render_process_id, render_view_id);
 }
@@ skipping 239 matching lines @@
 #if defined(USE_NSS)
 crypto::CryptoModuleBlockingPasswordDelegate*
     ChromeContentBrowserClient::GetCryptoPasswordDelegate(
         const GURL& url) {
   return browser::NewCryptoModuleBlockingDialogDelegate(
       browser::kCryptoModulePasswordKeygen, url.host());
 }
 #endif
 
 }  // namespace chrome