base::Bind: Convert net::NetworkDelegate.

base::Bind: Convert net::NetworkDelegate.

R=groby
BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112534

[James Hawkins, 2011-11-30 20:04:25]

+csilv

[groby-ooo-7-16, 2011-11-30 21:18:34]

lgtm

[csilv, 2011-11-30 21:56:49]

http://codereview.chromium.org/8743019/diff/1/net/base/network_delegate.cc
File net/base/network_delegate.cc (right):

http://codereview.chromium.org/8743019/diff/1/net/base/network_delegate.cc#ne...
net/base/network_delegate.cc:12: URLRequest* request, const
net::CompletionCallback& callback,
same comment as header (re: already in net namespace)

http://codereview.chromium.org/8743019/diff/1/net/base/network_delegate.h
File net/base/network_delegate.h (right):

http://codereview.chromium.org/8743019/diff/1/net/base/network_delegate.h#new...
net/base/network_delegate.h:53: const net::CompletionCallback& callback,
Since we're already in the net namespace, none of these need the net:: prefix. 
Not a necssary change, but i think it's worth considering.

http://codereview.chromium.org/8743019/diff/1/net/url_request/url_request_htt...
File net/url_request/url_request_http_job.cc (right):

http://codereview.chromium.org/8743019/diff/1/net/url_request/url_request_htt...
net/url_request/url_request_http_job.cc:213: this))),
should 'this' be unretained? (ie typical callback usage)

http://codereview.chromium.org/8743019/diff/1/net/url_request/url_request_htt...
net/url_request/url_request_http_job.cc:233:
base::Bind(&URLRequestHttpJob::OnHeadersReceivedCallback, this))),
ditto

http://codereview.chromium.org/8743019/diff/1/net/url_request/url_request_uni...
File net/url_request/url_request_unittest.cc (right):

http://codereview.chromium.org/8743019/diff/1/net/url_request/url_request_uni...
net/url_request/url_request_unittest.cc:19: #include "base/format_macros.h"
add include for base/memory/weak_ptr.h

[James Hawkins, 2011-12-01 00:40:25]

http://codereview.chromium.org/8743019/diff/1/net/base/network_delegate.cc
File net/base/network_delegate.cc (right):

http://codereview.chromium.org/8743019/diff/1/net/base/network_delegate.cc#ne...
net/base/network_delegate.cc:12: URLRequest* request, const
net::CompletionCallback& callback,
On 2011/11/30 21:56:50, csilv wrote:
> same comment as header (re: already in net namespace)

Done.

http://codereview.chromium.org/8743019/diff/1/net/base/network_delegate.h
File net/base/network_delegate.h (right):

http://codereview.chromium.org/8743019/diff/1/net/base/network_delegate.h#new...
net/base/network_delegate.h:53: const net::CompletionCallback& callback,
On 2011/11/30 21:56:50, csilv wrote:
> Since we're already in the net namespace, none of these need the net:: prefix.

> Not a necssary change, but i think it's worth considering.

Done.

http://codereview.chromium.org/8743019/diff/1/net/url_request/url_request_htt...
File net/url_request/url_request_http_job.cc (right):

http://codereview.chromium.org/8743019/diff/1/net/url_request/url_request_htt...
net/url_request/url_request_http_job.cc:213: this))),
On 2011/11/30 21:56:50, csilv wrote:
> should 'this' be unretained? (ie typical callback usage)

Done.

http://codereview.chromium.org/8743019/diff/1/net/url_request/url_request_htt...
net/url_request/url_request_http_job.cc:233:
base::Bind(&URLRequestHttpJob::OnHeadersReceivedCallback, this))),
On 2011/11/30 21:56:50, csilv wrote:
> ditto

Done.

http://codereview.chromium.org/8743019/diff/1/net/url_request/url_request_uni...
File net/url_request/url_request_unittest.cc (right):

http://codereview.chromium.org/8743019/diff/1/net/url_request/url_request_uni...
net/url_request/url_request_unittest.cc:19: #include "base/format_macros.h"
On 2011/11/30 21:56:50, csilv wrote:
> add include for base/memory/weak_ptr.h

Done.

[csilv, 2011-12-01 00:44:08]

lgtm

[commit-bot: I haz the power, 2011-12-01 03:55:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jhawkins@chromium.org/8743019/8001

[commit-bot: I haz the power, 2011-12-01 03:55:29]

Presubmit check for 8743019-8001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
net/url_request/url_request_unittest.cc,net/base/network_delegate.h,net/url_request/url_request_test_util.cc,net/url_request/url_request_http_job.h,net/url_request/url_request_test_util.h,net/proxy/network_delegate_error_observer_unittest.cc,chrome/browser/net/chrome_network_delegate.cc,net/url_request/url_request.cc,chrome/browser/net/chrome_network_delegate.h,net/base/network_delegate.cc,net/url_request/url_request_http_job.cc,net/url_request/url_request.h

Presubmit checks took 2.2s to calculate.